YV12: mpeg2dec, mpeg2dec2 and mpeg3dec developers

[iago]

i'll try to release MPEG2Dec3 beta 7 with YUY2/YV12 choice and cleanded settings.

Marc,

Nice to hear that! I'm really looking forward to it and getting the lumoff parameter back again!

regards,
iago

[ookzDVD]

Yes, I finally could notice some YV12 speed improvement over the
YUY2... it's about 10-15% on my machine... not bad

[Koepi]

@MarcFD:

Any progress with mpeg2dec3+yv12 choice / beta7?

@all:

How's vdub-mod coming along? =

Best regards,
Koepi

[vlad59]

As it seems there is two thread about Avisynth 2.5, I also post here.

The first beta of Convolution3DYV12 is out you can find it here

Thnaks in advance for the feedback

[MaTTeR]

Originally posted by vlad59
The first beta of Convolution3DYV12 is out

Very cool Vlad. My testing begins in about 9hrs from now

BTW- The readme is showing all presets using the same values of- (0, 32, 128, 32, 128, 10, 0).

Edit- First impressions of the speed seem to be pretty good.

LoadPlugin("C:\Program Files\AviSynth2\plugins\MPEG2DEC3_YV12.dll")
mpeg2source("D:\Lost\lost.d2v",iDCT=2,cpu=1,moderate_h=45,moderate_v=65)
crop(8,58,704,368)
UnDot()
Convolution3D(0,2,3,2,3,2.8,0)
LanczosResize(624,264)

Averaging 29FPS with XviD and Chroma motion at Motion Search 6, latest dev build from Koepi. Thx Vlad

[vlad59]

Originally posted by MaTTeR
Very cool Vlad. My testing begins in about 9hrs from now

BTW- The readme is showing all presets using the same values of- (0, 32, 128, 32, 128, 10, 0).

Do you mean that the presets don't work anymore ?????

[Rrrough]

@vlad59

thank you very much for your yv12 implementation of convolution3d. will try it asap.

@all

suxen_drol from the xvid-development team developed external colorspace api support, so there is YV12 preview with vdub(mod) and XVID support already committed to CVS. it's supposed to be faster than divx5 too.

cheers

[iago]

@vlas59

Thanks for convolution3d YV12! Gonna try it asap!

@Marc

Any good news on the mpeg2dec3 beta7 side?

regards,
iago

[Marc FD]

>Any progress with mpeg2dec3+yv12 choice / beta7?

it's WE, so i'm gonna work on it.
I've a problem. maintain compatibility with avisynth 2.06 will be a source of bugs and would cost me to much time for packaging,ect..

and you all know i prefer the coding part ^^

so i'm gonna make MPEG2Dec3 beta7 compatible ONLY with Avisynth 2.5. It's beta now, and more users would help to improve stability.

It'll ONLY output in YV12, but i'll add the internal YV12->YUY2 convertion (for debugging, and to keep compatibility with MPEG2Dec. MPEG2Dec3 would still be able to give the same results than MPEG2Dec. (maybe not exactly, because of the ssemmx Motion Compentation)

i need to find a _very_ accurate way of detecting combing on MPEG-2 streams. i think i'll add a pratical-check : search for combing on the frames. if auto-combing check detection work, it would output a field based clip.

so i've some ideas for next versions. i'll try to release MPEG2Dec3 beta7, with bugfixes, and minor changes first. new features would wait for beta 8.

@vlad59

cool ! bravo.

[trbarry]

Marc -

Is source available anywhere for your MPEG2DEC3 YV12?

I guess yours does not handle HDTV streams so I'm going to have to do MPEG2DEC2, but I'm lazy.

- Tom

[Marc FD]

>I guess yours does not handle HDTV streams so I'm going to have to do MPEG2DEC2, but I'm lazy.

it's based on save-oe (MPEG2Dec2) and there's pid stuff in it. i guess it should be able to handle HDTV streams. if not, just say what you need, i'll add it ^_^

[MaTTeR]

Originally posted by vlad59
Do you mean that the presets don't work anymore ?????

No, sorry that's not what I meant. Presets appear to work fine for me so far. In your readme(documentation) file it shows that all presets use the same parameters Copied and pasted here-

2 - Parameters sample

I build the following presets to make things easier :
Convolution3d (preset="movieHQ") // Movie Hi Quality (good DVD source)
	is an alias for Convolution3D (0, 32, 128, 32, 128, 10, 0) 
Convolution3d (preset="movieLQ") // Movie Low Quality (noisy DVD source)
	is an alias for Convolution3D (0, 32, 128, 32, 128, 10, 0) 
Convolution3d (preset="animeHQ") // Anime Hi Quality (good DVD source)
	is an alias for Convolution3D (0, 32, 128, 32, 128, 10, 0) 
Convolution3d (preset="animeLQ") // Anime Low Quality (noisy DVD source)
	is an alias for Convolution3D (0, 32, 128, 32, 128, 10, 0) 
Convolution3d (preset="animeBQ") // Anime Bad Quality (???)
	is an alias for Convolution3D (0, 32, 128, 32, 128, 10, 0)

[trbarry]

>"I guess yours does not handle HDTV streams so I'm going to have to do MPEG2DEC2, but I'm lazy."

it's based on save-oe (MPEG2Dec2) and there's pid stuff in it. i guess it should be able to handle HDTV streams. if not, just say what you need, i'll add it ^_^

Marc -

Okay, I guess that means the source isn't available. I really hate to lose my SSE2 speed advantage.

But I only tried it a couple times with ATSC streams but got an error on both files so I switched my YV12 testing to DVD material. Since I didn't have source I didn't try to debug it much. I'll go test some more and check and see if it is just something simple in the d2v file and let you know.

Does your code read the PID numbers in the d2v file? Or is that part of the code the same also? In doubt, my version source is still at:

www.trbarry.com/MPEG2DEC2.zip

- Tom

[Marc FD]

>Okay, I guess that means the source isn't available. I really hate to
>lose my SSE2 speed advantage.

i removed the sse2 stuff, because it crashed for P4 owners. i'm not sure your sse2 MC is working. BTW, sse2 iDCT works, and it's more important than MC (speed-wise)

>But I only tried it a couple times with ATSC streams but got an error on
>both files so I switched my YV12 testing to DVD material. Since I
>didn't have source I didn't try to debug it much.

It's transport packet stream compatible.

>I'll go test some more
>and check and see if it is just something simple in the d2v file and
>let you know.

>Does your code read the PID numbers in the d2v file?

yes, with Stream_Type=2,[..],[..] and MPEG2_Transport_PID=VideoPID,[..] is recognised. i think it should work. i hope i didn't broke something.

[int 21h]

Why isn't the source to mpeg2dec3 available?

[vlad59]

Originally posted by Marc FD
It'll ONLY output in YV12, but i'll add the internal YV12->YUY2 convertion (for debugging, and to keep compatibility with MPEG2Dec. MPEG2Dec3 would still be able to give the same results than MPEG2Dec. (maybe not exactly, because of the ssemmx Motion Compentation)

If I remember well (it's been a long time) the ssemmx MC code I send to you has the same accuracy as the original MMX code. I had also written some Fast&dirty one (a little faster less than 1% but not accurate at all). So If you kept my code there shouldn't be not problem.


@MaTTer

That's the problem when you make the tests on the laptop and make the release on the _normal_ computer -> some copy/paste are not automatical
I'll fix that soon.

[Marc FD]

>If I remember well (it's been a long time) the ssemmx MC code I send to
>you has the same accuracy as the original MMX code. I had also written
>some Fast&dirty one (a little faster less than 1% but not accurate at
>all). So If you kept my code there shouldn't be not problem.

yes you're right. i've even made tests between MPEG2Dec and MPEG2Dec3 and the results were 100% the same (and the speed almost the same too, maybe about 5-10% speedup ^^)

>Why isn't the source to mpeg2dec3 available?

no fear. i know it's GPL code, if you WANT it, you'll get it. but if i don't give it, it's because i'll need a _lot_ of time to clean what i've done and i think it's a waste of time. i prefer concentrate on usefull coding. if someone complain, no problem, i would stop to release it ^_^.

BTW, i've finished Focus2 - YV12. i'm gonna release it soon.

[int 21h]

Originally posted by Marc FD
no fear. i know it's GPL code, if you WANT it, you'll get it. but if i don't give it, it's because i'll need a _lot_ of time to clean what i've done and i think it's a waste of time. i prefer concentrate on usefull coding. if someone complain, no problem, i would stop to release it ^_^.

I'd prefer you just obey the GPL like everyone else does (trbarry, neuron2, sh0dan, etc.) No one around here cares how messy your code is, and in fact, some might even help you clean it up a bit.

Not like I'm asking for an entirely documented project, pseudo-code, algorithms, and incode comments, just that you obey the original intent of the code (So that if Tom indeed wanted to investigate the issues with transport streams in the code, he could).

[trbarry]

Marc -

I don't mean to be pushy but probably the only reason there IS an MPEG2DEC3 with all these nifty features is because there was open source to MPEG2DEC2, which wasn't cleaned up either.

And the ony reason there was an MPEG2DEC2 was because there was available source to DVD2AVI and MPEG2DEC that a whole bunch of people contributed to, making this sort of thing possible.

I'm not the original author of either of them but I'd like to see them continue to evolve. You are doing a quite admirable job in this area, but there is still only one of you. If you made it available then, like me, you would probably find that open source is a bit like karma ... what goes around, comes around. You'll find that other people add useful functions to it also.

And I don't think you are in a position to easily test and debug either ATSC/HDTV or SSE2 support but it would still be a shame if this caused those functions to disappear.

And frankly, I'm still too lazy to go code YV12 MPEG2DEC2 output routines if I know there are already functional ones based upon that code.

How about if you post those output source functions and leave the rest 'til it's cleaned up and convenient? Possible? No demands, just a suggestion.

- Tom

[Marc FD]

>I don't mean to be pushy but probably the only reason there IS an
[...]
>And I don't think you are in a position to easily test and debug
>either ATSC/HDTV or SSE2 support but it would still be a shame if this
>caused those functions to disappear.

i think i wasn't clear. i'm addicted to opensource devellopement. no problem with that. if you want the source, just email me, i'll give it to you ASAP. my problem is packaging.

>And frankly, I'm still too lazy to go code YV12 MPEG2DEC2 output
>routines if I know there are already functional ones based upon that code.

you're are overestimating me. YV12 support is a 10 min hack.

>How about if you post those output source functions and leave the rest
>'til it's cleaned up and convenient? Possible? No demands, just a
>suggestion.

i think the best way is :
you email me, i send you the code, you test all sse2 parts of the code, make a sse2 version of the new MC, HDTV support, ect...
and you (please ^^) say me what's changed, so i can update it, and every user could benefit from it.

my only fear is to have 2 differents versions.
but i think opensource devellopement can be very productive.
i know well MPEG2Dec's code, you too, i think we can easily work together on the same project.

Regards,
MarcFD

PS : if someone want the code, just e-mail me. i don't think it's really interessing. BTW, when it would be stable, i'ld clean the code and package the source code. i just don't like too lose 50% of my time in code packaging of beta versions.