DGMPGDec 1.4.0 Final!

[CyberGuy]

Originally posted by neuron2
As a quick test, here is a hack that does this (mpeg2source() only). Someone please test it under 2.5.6b3.

http://neuron2.net/dgmpgdec/DGDecodeX.zip

I just did this:

PVideoFrame frame = env->NewVideoFrame(vi, -16);

EDIT: It appears I need -8 instead of -16. I'll put up another version tonight.

It still returns a Video Pitch of 736 bytes with AviSynth 2.5.6b3 when it should be 720 bytes.

LoadPlugin("DGDECODEX.DLL")
Source = Mpeg2Source("Video.D2V", iDCT=4, CPU=0)
Return(Source)

[Cyberia]

FYI: This didn't fix it.

[neuron2]

Hellooooo?! Didn't you guys read my EDIT?

Download using the same link to get the one I just put up. It uses -8. Please test that one. Thank you!

[Cyberia]

Fixed

[CyberGuy]

Originally posted by neuron2
Hellooooo?! Didn't you guys read my EDIT?

Download using the same link to get the one I just put up. It uses -8. Please test that one. Thank you!

It works! Thanks for the quick fix. Now I notice that LanczosResize/Lanczos4Resize breaks it again, but I guess that's a post for another thread.

[neuron2]

@CyberGuy

Please post the script that breaks. Thank you.

[CyberGuy]

Originally posted by neuron2
@CyberGuy

Please post the script that breaks. Thank you.

LoadPlugin("DGDECODE.DLL")
Source = Mpeg2Source("VIDEO.D2V", iDCT=4, CPU=0)
Source = Trim(Source, 70, 3145)
Source = Crop(Source, 0, 76, -0, -76)
Source = LanczosResize(Source, 720, 304, Taps=8)
Return(Source)

If I comment out "Source = LanczosResize(Source, 720, 304, Taps=8)", then it plays correctly in MPlayer. The LancosResize changes the Video Pitch from 720 to 736. The original source is 720x576. If resizing to 704x304, then the video pitch is 704, so this appears to happen when width is not changed.

[cw_uk]

Is it possible thats theres a problem with DGIndex not flushing the last frames from a previously loaded file, Whilst backing up Agent Cody Banks i noticed on the finished file that the first frame or two was from the menu which i had loaded just to check it out before hand. the finished file had audio/video sync issues which might have been down to this. im reencoding the file now to confirm.

[neuron2]

Originally posted by CyberGuy
The LancosResize changes the Video Pitch from 720 to 736.

You need to report this in the Avisynth beta thread. Apparently there are several filters that need to be revised to work with the new alignment.

@cw_uk

It's highly doubtful. Maybe you forgot to delete the VOB from the VOB list.

[CyberGuy]

Originally posted by neuron2
You need to report this in the Avisynth beta thread. Apparently there are several filters that need to be revised to work with the new alignment.

It's not a problem after all, I had read in one of the forum posts mod 16, but it's actually mod 32, so AviSynth 2.5.6 is working correctly.

See: http://forum.doom9.org/showthread.ph...0&pagenumber=2

[neuron2]

Here is beta 4. This version corrects a decoding error caused by improper recovery from an MPEG2 syntax error (caused by corruption of a transport stream). The issue is described in this thread:

http://forum.doom9.org/showthread.php?s=&threadid=94382

Here is the fixed version:

http://neuron2.net/dgmpgdec/dgmpgdec131b4.zip

[guada 2]

Gently but surely.
I appreciate your step of work.

Thank you very much Neuron2 and long life with DGindex and the devellopor which contribute to waitings of the listeners of planet.

Goodbye

[cw_uk]

Originally posted by neuron2
@cw_uk

It's highly doubtful. Maybe you forgot to delete the VOB from the VOB list.

Reripped it and this time all is fine no more stray few frames knocking everything out of sync, The only thing that i did diffrently though was not check the menu (Vob 0) this time. I thought the same as you to begin with but if i had forgot to remove the entire menu vob from the list i would have the entire menu appended to the beginning of the movie.

[neuron2]

Originally posted by cw_uk
The only thing that i did diffrently though was not check the menu (Vob 0) this time.

I don't know what you are talking about. "Check the menu"? That doesn't sound like a DGIndex operation.

[cw_uk]

Originally posted by cw_uk
Is it possible thats theres a problem with DGIndex not flushing the last frames from a previously loaded file, Whilst backing up Agent Cody Banks i noticed on the finished file that the first frame or two was from the menu which i had loaded just to check it out before hand. the finished file had audio/video sync issues which might have been down to this. im reencoding the file now to confirm.

Originally posted by neuron2
You need to report this in the Avisynth beta thread. Apparently there are several filters that need to be revised to work with the new alignment.

@cw_uk

It's highly doubtful. Maybe you forgot to delete the VOB from the VOB list.

Originally posted by cw_uk
Reripped it and this time all is fine no more stray few frames knocking everything out of sync, The only thing that i did diffrently though was not check the menu (Vob 0) this time. I thought the same as you to begin with but if i had forgot to remove the entire menu vob from the list i would have the entire menu appended to the beginning of the movie.

VTS_01_0 <-- menu VOB

apologies for my lack of words and effort but im off to bed and couldnt be bothered to type out a explaination.

[sh0dan]

Originally posted by neuron2
EDIT: It appears I need -8 instead of -16. I'll put up another version tonight.

DON'T DO THAT, unless you realign frames afterwards (by a bitblit). Planar images returned by your filter MUST have mod 16 on the Y-plane pitch. This is not guaranteed by using "-8". You risk breaking a bunch of filters that process 16 bytes/loop. Snippet from the documentation (from WorkingWithPlanarImages):

Some (producing) filters may want to set a forced pitch. Per default, when you request a videoframe with a specific modX pitch it might be overruled by AviSynth.(You do this by using env->NewVideoFrame(VideoInfo, [alignment])) In this (very rare case), you can use a negative alignment. This will make the alignment forced.

If you force an alignment you MUST also apply the AlignPlanar(!PClip) filter after your own, otherwise your filter will not produce valid output. See source.cpp for examples.

[neuron2]

The -8 sets up 8-alignment on the chroma and 16-alignment on the luma under the new beta.

[neuron2]

Here is 1.3.1 beta 5. This beta adds a fully correct fix for the pitch=width assumption, thereby allowing correct operation under the current Avisynth 2.5.6 beta, as well as the stable 2.5.5 version. Our friend tritical kindly developed and contributed this code revision. Thank you, tritical!

tritical also removed the limitation of a maximum of 1,000,000 frames.

I added a fix for the emulated header problem by properly parsing the pack layer or transport layer if needed when getting the initial sequence header.

I also corrected an error in the D2V file format document.

Please beat up on this hard because the changes are extensive. Thank you.

http://neuron2.net/dgmpgdec/dgmpgdec131b5.zip

[iNFO-DVD]

Just tried your beta5, remember that 'green line' (earlier post) I was getting down the left side on certain clips..... well it's now gone.

Well done.

[neuron2]

@iNFO-DVD

Thank you for your test result. That is good to know.