PgcEdit v0.3.

[2COOL]

@blutach

I replied to your post in its appropriate thread.

[r0lZ]

Originally posted by 2COOL
Request:

Instead of blanking cells at a cell level, how about at a PGC level? Here's my visualization.

The Blank Cell(s) button would be disabled until a check is made on the right. No action will be made until button is pressed and you'll have a dialog, not corrected though, with info as below. You know what I'm getting at.

This would be useful on blanking specific cells in one process. All cells selected in this PGC would be referenced to just one new blank cell. What do you think?

That's feasible, but you can already do that with a few mouse clicks.

I have planned to revamp totally this part of the interface. IMHO, it will be better to have two completely different GUIs: one for the PGC header, streams lists and color lookup table. The other one with the Cell table. With this new interface, you will be able to multi-select any number of cells, and process them as a whole, to add, remove or move up/down the program and chapter entries, or to remap or blank the cells.

However, I will have a look at the code. If your suggestion is easy to program, I will implement it.

Or I may add an external function, working at the PGC level, to blank (or remap) ALL cells of the PGC in one operation.

[Cela]

Commands or macro for VTS-chain needed - Call for help:

Given three VTST from DVD-lab Pro with 'File > Attach External VTS' attached to a dummy VTS1 (blank VOB):
VTS2 with 40 chapters
VTS3 with 33 chapters
VTS4 with 41 chapters

Wanted to step forward and backward from chapter to chapter with the 'next chapter' and with the 'previous chapter' button of the remote control as if the logical chain of the concatination of all chapters of the three VTS belonged to a virtual single VTS. An innocent wish but complicated to express in english and impossible for me to accomplish.

Forward Chain:
Using the 'next chapter button' jump from the current chapter to the next chapter until the last chapter of the current VTS is reached and then jump to the first chapter of the next VTS...

Menu VMGM PGC2 ->
-> VTS2, PGC1, Chapter1 ! -> 'next chapter button'
-> VTS2, PGC1, Chapter2
...
-> VTS2, PGC1, Chapter39
-> VTS2, PGC1, Chapter40 ! last chapter of VTS2

-> VTS3, PGC1, Chapter1 ! first chapter of VTS3
-> VTS3, PGC1, Chapter2
...
-> VTS3, PGC1, Chapter32
-> VTS3, PGC1, Chapter33 ! last chapter of VTS3

-> VTS4, PGC1, Chapter1 ! first chapter of VTS4
-> VTS4, PGC1, Chapter2
...
-> VTS4, PGC1, Chapter40
-> VTS4, PGC1, Chapter41 ! last chapter of VTS4

-> back to Menu VMGM PGC2

Backward Chain:
Using the 'previous chapter button' jump from the current chapter to the previous chapter until the first chapter of the current VTS is reached and then jump to the last chapter of the previous VTS...

<- back to Menu VMGM PGC2
<- VTS2, PGC1, Chapter1 ! first chapter of VTS2
<- VTS2, PGC1, Chapter2
...
<- VTS2, PGC1, Chapter39
<- VTS2, PGC1, Chapter40 ! last chapter of VTS2

<- VTS3, PGC1, Chapter1 ! first chapter of VTS3
<- VTS3, PGC1, Chapter2
...
<- VTS3, PGC1, Chapter32
<- VTS3, PGC1, Chapter33 ! last chapter of VTS3

<- VTS4, PGC1, Chapter1 ! first chapter of VTS4
<- VTS4, PGC1, Chapter2
...
<- VTS4, PGC1, Chapter40
<- VTS4, PGC1, Chapter41 ! <- 'previous chapter button'

I managed to do the forward chain, but I am unable to do the backward chain. Help needed. Thanks.

[2COOL]

@Cela

Originally posted by Cela

Backward Chain:
Using the 'previous chapter button' jump from the current chapter to the previous chapter until the first chapter of the current VTS is reached and then jump to the last chapter of the previous VTS...

I managed to do the forward chain, but I am unable to do the backward chain. Help needed. Thanks. [/B]

To the best of my knowledge, this is not possible.

@r0lZ

A DVD can have more than one PGC holding the same title (Non_sequential_PGC Titles). In PgcEdit, you only have one VTST defined while another with the same title, showing nothing (undefined). It is possible to get the PGC's title number from VTs_PGCITI.

[r0lZ]

@2COOL

A DVD can have more than one PGC holding the same title (Non_sequential_PGC Titles). In PgcEdit, you only have one VTST defined while another with the same title, showing nothing (undefined). It is possible to get the PGC's title number from VTs_PGCITI.

I know. I made it this way deliberately. The Title label identifies the entry point of the title. I use this info for the highlight/jump to target features.

Note that you can find the other PGCs belonging to the same title by looking at the TTN number: all PGCs with the same TTN number are different parts of the same non-sequential title.

BTW, I can't imagine a good reason to spread a title over several PGCs. Do you?

[Cela]

To the best of my knowledge, this is not possible.

...and when the BEST says it is not possible, then its hopeless.

But as you say: "Without vision, we are blind to opportunity."

Can we find a workaround?

DVBlab's 'bridge element' is a first approximation to a solution. Here you jump from 'first chapter of current VTS' to 'FIRST chapter of previous VTS'!
Which is not yet the natural, logical sequence in the film.

So, if its possible to jump to the 'FIRST chapter of previous VTS', isn't it possible to put there a precommand that tells to jump on to the LAST chapter. (The number of the LAST chapter could be edited manually with PgcEdit). Probably a free GPRM is needed which could trigger the jump to the LAST chapter. It should be ON when the pending user action is a 'previous chapter button' click. Unfortunately, I am a simple user and my knowledge is too limited to activly seek a solution.

Now a reason for such an example. Why do I bother you with this example? I simply want to be able to browse through a film in the natural, logical order - even when the film has to be segmented.

Imagine there is a film which would need 114 chapters (major scene changes), too many for a single VTS.
Since it consists of three major parts, I would like to segment it into three segments (if that is not possible, I will have to be content with two segments):
segment 1: let original chapters 001 - 040 become VTS2 with ch. 1-40 (call it A1 - A40)
segment 2: let original chapters 041 - 073 become VTS3 with ch. B1 - B33
segment 3: let original chapters 074 - 114 become VTS4 with ch. C1 - C41

a schematic graphic could be like this:

!01____....______40_41____...______73_74____..._____114! original Film
-------------------------------------------------------------------
!A1_A2_..._A39_A40!B1_B2_..._B32_B33!C1_C2_..._C40_C41! segmented into three parts
-------------------------------------------------------------------
!_____VTS2_______!_____VTS3_______!_____VTS4_______!


In the original film there is no problem to browse forwards and backwards with the appropriate chapter buttons.

But how to browse ...
from original 'chapter 41' -> 'chapter 40'
that is from 'VTS3 chapter 1' -> 'VTS2 chapter 40'
or generally from 'FIRST chapter of VTS3' -> 'LAST chapter of VTS2'
more generally from 'first chapter of current VTS' -> 'last chapter of previous VTS' with the 'previous chapter button'?
... that is the question.

With my limited knowledge I cannot find a solution!
But I'm sure, you can.

Cela

[2COOL]

@r0lZ

You have lots of discrepancies in PgcEdit!

1. I don't think you can set the highlighted button with a SPRM value. This is in regards to http://www.dvd-replica.com/DVD/sethlbtn.php You can only used a GPRM or 6-bit button value.
   
2. From http://www.dvd-replica.com/DVD/cmpgprmops.php
   
   

   A compare operation compares the contents of a specified GPRM to another GPRM, SPRM or a constant value.

   I don't think you can use a SPRM to compare with another GPRM, SPRM, or a constant value. The first value must always be a GPRM. Show me a DVD that has a If-SPRM command as I have check through 5 DVDs so far and none have them. With this said, you have to redo alot of dialogs with these If-SPRM commands.
   
3. In SetCLnk, I don't think you can assign a SPRM value to a GPRM. I can't confirm for CSetLnk though.
   
4. In SetAMXMD dialog, I don't think you can set SPRM 11 the way it's set up. In fact, I think your command editing dialog for this command is wrong. here. It should be setting channel mixing flags.
   
5. In SetGPRMMD, I don't think you can assign a SPRM value to a GPRM.
   
6. When using RND with GPRM, you can't use zero as the seed value. In fact, when I inputted this command I got an error when doing a PGC dump after.
   

   [78 00 00 00 00 00 00 00]   #  Set gprm(0) ?=(rnd) 0

   can't read "::menus(0,1,2,numcells)": no such element in array

7. Hmmm....using a in-place NOP command, I selected Numerically > 40-D0: Set > A_____CSetCLnk. Keep doing this with the others in the same list and look at the hex command. It doesn't update correctly. Is it just me?
   
8. Why is that when I set a GPRM and then do a LinkPGCN, I don't have the option to highlight a button? All the other link commands do. It should be in the specs. [Edit] Hmmm...maybe we can't really do it and dvd-replica.com is wrong. It's not the first time that site's wrong.
   
   Also you got Number of PGCs at 65535? Seems kind of high. Hmmm....here's mpucoder input on number of PGCs per IFO, http://forum.doom9.org/showthread.ph...89#post371189.
   
   And another thing, if inputting a 0 or blank into PGCN results in an illegal command, why even let it be inputted. You have filtered out other character besides 0 to 65535. Same goes for LinkPGN, LinkPTT, and LinkCN.
   
9. Not a discrepancy, but in the NOP command dialog, why even bother enabling the "IF" checkbox is you state that using it is useless.
   
10. Try these commands in PGC command editor.
    
    {68 00 00 00 00 00 00 00} // RND
    {69 01 00 00 00 00 00 00} // AND
    {6A 01 00 00 00 00 00 00} // OR
    {6B 01 00 00 00 00 00 00} // XOR
    
    If you toggle the R And, the LinkNoLink command still remains in the code even if you don't have it checked.

Can you prove me wrong with justifications? I have been reading my book, DVD Authoring and Production by Ralph LaBarge, and it also backs up what I report. There may be more if I do more research.


UPDATE:More errors found!

There might be case that it is possible that an error occurs through the executioin of a navigation command. The DVD Specs requires the player to perform the following actions when an error condition occurs.

If a GPRM is divided or mod by zero, PgcEdit reports an error.

[77 00 00 00 00 00 00 00]   #  Set gprm(0) %=(mod) 0
[76 00 00 00 00 00 00 00]   #  Set gprm(0) /=(div) 0

Error:divide by zero

According to my book, if this is command is used, the target GPRM will be set to 65,535.

divide by zero
divide by zero
    while executing
"expr $op1 / $val"
    ("6" arm line 2)
    invoked from within
"switch $operand {
		1 { ;# = SET
			return $val
		}
		2 { ;# <-> SWAP !!! NOT SWAPPED: actually, this function allow only to return ONE value!
			retu..."
    (procedure "operation_result" line 2)
    invoked from within
"operation_result $op1 $operand $val"
    ("7" arm line 25)
    invoked from within
"switch $cmdtype {
		0 {
			# flow control commands
			switch [::disasm::get_nibble $hex 1 1] {
				0 {
					# NOP
				}
				1 {
					# Goto
					set n..."
    (procedure "trace_disasm" line 16)
    invoked from within
"trace_disasm"
    ("default" arm line 14)
    invoked from within
"switch $cmdtype {
		"* pre" {
			incr idx
			::main::set_listbox_selection $idx
		}
		"* post" {
			incr idx
			::main::set_listbox_selection $idx
		}..."
    (procedure "exec_current_line" line 11)
    invoked from within
"exec_current_line"
    invoked from within
"if {$idx == "-"} {
				::main::set_listbox_selection end
				set idx [lindex [::main::get_selection_indexes] 0]
				bell
			} elseif $::tr::now_playin..."
    (procedure "step" line 5)
    invoked from within
"step	"
    (procedure "::tr::dvd_trace" line 280)
    invoked from within
"::tr::dvd_trace"
    (menu invoke)

Also if the navigation command results in an overflow, then the target GPRM will be set to 65,535. If the overflow occurred while a GPRM was in counter mode, then the target GPRM will be set to zero.

If a navigation command results in an underflow, then the target GPRM will be set to zero.

[2COOL]

Suggestion:

When using Set commands with

ADD
SUB
MUL
DIV
MOD
RND
SWP
AND
OR
XOR

.., a disclaimer to state that these commands cannot be used if the target GPRM is in counter mode.

[r0lZ]

Originally posted by 2COOL
@r0lZ

You have lots of discrepancies in PgcEdit! [list=1][*] I don't think you can set the highlighted button with a SPRM value. This is in regards to http://www.dvd-replica.com/DVD/sethlbtn.php You can only used a GPRM or 6-bit button value.[/list=1]

From MPUCoder's site:

The SetHL_BTNN command sets the selected (highlighted) button number (SPRM 8).
The indirect form sets SPRM 8 to the value in register (GPRM or SPRM) "SS" (byte 5).
The direct form sets SPRM 8 to "SSSS" (bytes 4&5).

I will try to do some tests to confirm...

[EDIT] Tested with IfoEdit, WinDVD, Sony and Kiss: it works perfectly!

[r0lZ]

Originally posted by 2COOL
2. From http://www.dvd-replica.com/DVD/cmpgprmops.php

I don't think you can use a SPRM to compare with another GPRM, SPRM, or a constant value. The first value must always be a GPRM. Show me a DVD that has a If-SPRM command as I have check through 5 DVDs so far and none have them. With this said, you have to redo alot of dialogs with these If-SPRM commands.

Again, this is not what is explained on the MPUCoder's site. But it's not verry clear...

Tested with IfoEdit, WinDVD, Sony and Kiss: it works perfectly!

EDIT: I was wrong! Fixed in PgcEdit 0.4.7.

[r0lZ]

3. In SetCLnk, I don't think you can assign a SPRM value to a GPRM. I can't confirm for CSetLnk though.

MPUCoder's site:

The SetCLnk command sets the destination register "R" (byte 1 lower nibble) to the result of the operation "J", listed below. A compare is then performed, and the link executed if the result of the compare is true.
The indirect form uses GPRM or SPRM denoted by "SS" (byte 3) as the source, as allowed by the operation.
The direct form uses the constant "SSSS" (bytes 2&3) as the source value, if allowed by the operation.

Tested with IfoEdit, WinDVD, Sony and Kiss: it works perfectly!

[r0lZ]

4. In SetAMXMD dialog, I don't think you can set SPRM 11 the way it's set up. In fact, I think your command editing dialog for this command is wrong. here. It should be setting channel mixing flags.

That's almost true. For this command, the PgcEdit's interface is somewhat limitted.

You can use a GPRM or SPRM as the source for the operation. The GUI is correct on this point.

You can use a constant value as well, but only some values are legal. Only bits 2-4 and 10-12 are meaningful. Bits 0, 1, 5-9 and 13-15 must be set to 0. This is why the maximum value allowed in the GUI is 7196 (ie 0x1C1C, meaning all legal bits set.) However, it is possible to enter an illegal value here (for example: 1, meaning bit 0 set, is illegal, but can be entered).

Ideally, I should replace the source value field by 6 checkboxes. It's on my TODO list for a while. But it's not easy to do (I use the same GUI for all sources allowing to input a value, a GPRM or a SPRM.) For now, you have to calculate yourself the correct value to use.

Since this command is rarely used, changing the GUI is not a high priority TODO item for me. Sorry.

[r0lZ]

5. In SetGPRMMD, I don't think you can assign a SPRM value to a GPRM.

Again, from MPUCoder's site:

The indirect form uses the value in the register (GPRM or SPRM) indicated by "SS" (byte 3).

However, you are right! Using

[43 00 00 88 00 8F 00 00]   3  (SetGPRMMD) Set gprm(15) in counter mode =(mov) sprm(8:Highlighted button number)

will set the value of gprm(8) in gprm(15). (Tested on my Sony player and IfoEdit.)

I must fix this bug...

[r0lZ]

6. When using RND with GPRM, you can't use zero as the seed value. In fact, when I inputted this command I got an error when doing a PGC dump after.

[78 00 00 00 00 00 00 00]   #  Set gprm(0) ?=(rnd) 0

can't read "::menus(0,1,2,numcells)": no such element in array

The source value is not used as the random generator's seed. MPUCoder:

set destination GPRM to a random value between 1 and the source value

Obviously, it is meaningless to use a value of 0 or 1 here. But using 0 is not illegal.

Again, tested on all my players: surprise: the command

[78 00 00 00 00 00 00 00]   1  Set gprm(0) ?=(rnd) 0

gives 1 on all software players I have tested, including the Kiss standalone (which is in fact a Linux PC in a settop box).
But my Sony gives 0!

I may change the minimum to 1 in the GUI, but I'm not sure since it is apparently allowed to use 0 (with unpredictable results, but it is what you want when using a random generator, no? )

BTW, the error message you got is not related to this. Can you reproduce the problem?

[r0lZ]

7. Hmmm....using a in-place NOP command, I selected Numerically > 40-D0: Set > A_____CSetCLnk. Keep doing this with the others in the same list and look at the hex command. It doesn't update correctly. Is it just me?

Well. It's a little strange, but you must understand how it works.
The commands in this group (all *Set* commands) are duplicated in the 'Numerically' menu because there are actually two codes for each command: one code for the indirect Set (where the source is a GPRM or a SPRM), the other for the direct set (source is a constant value).
But both menu entries are calling the same command in the GUI. I don't change automatically the source type (GPRM/SPRM <-> value), because you can do that yourself, with the radio buttons in the GUI, and changing that without an explicit user action may be disturbing.

However, this behavior can be modified. Let me know if you want the source mode automatically updated...

[2COOL]

Originally posted by 2COOL
I don't think you can set the highlighted button with a SPRM value. This is in regards to http://www.dvd-replica.com/DVD/sethlbtn.php You can only used a GPRM or 6-bit button value.

Tested with IfoEdit, WinDVD, Sony and Kiss: it works perfectly!

What about the other 23 SPRMs besides SPRM (8)?

[r0lZ]

8. Why is that when I set a GPRM and then do a LinkPGCN, I don't have the option to highlight a button? All the other link commands do. It should be in the specs. [Edit] Hmmm...maybe we can't really do it and dvd-replica.com is wrong. It's not the first time that site's wrong.

It is not possible to have both a PGC value and a button number: the value is stored in bytes 6 and 7, and the button number in byte 6. Since the PGC number may be higher than 1023, it will overwrite the button number.
This is why the highlight button parameter is not supported by the standard.

Also you got Number of PGCs at 65535? Seems kind of high. Hmmm....here's mpucoder input on number of PGCs per IFO, http://forum.doom9.org/showthread.ph...89#post371189.

Right. I will change the max to 32767.

And another thing, if inputting a 0 or blank into PGCN results in an illegal command, why even let it be inputted. You have filtered out other character besides 0 to 65535. Same goes for LinkPGN, LinkPTT, and LinkCN.

You must remove the last character in the field to be able to type a different value.
Also, you must type 0 alone in the field to input an hexadecimal or octal number (ie 0x10 or 012).
So, there are 4 cases where the input field may be filled with illegal characters: "0" (when the minimum is 1), "", "0x" and "0X". In these situations, the field's value is assumed to be 0. This is why the generated command is illegal. The pink background is there to invite the user to continue to type... I can't do more.

[r0lZ]

Originally posted by 2COOL
What about the other 23 SPRMs besides SPRM (8)?

It works. But I must admit that it is not verry useful! And it is illegal to set the highlighted button to a number which is not a multiple of 1024. So, using a SPRM as the source will probably have unpredictable results, and is probably never used. But it works, and therefore PgcEdit must support it (or you will have surprises when entering the command editor with such a command.)

[r0lZ]

9. Not a discrepancy, but in the NOP command dialog, why even bother enabling the "IF" checkbox is you state that using it is useless.

For the same reason: it works! If you have a command like this one

[00 A0 00 00 00 00 00 00]   1  if ( gprm(0) == 0 ) then { NOP }

I must show the IF condition in the GUI, or the command will not be translated correctly.

[r0lZ]

10. Try these commands in PGC command editor.

{68 00 00 00 00 00 00 00} // RND
{69 01 00 00 00 00 00 00} // AND
{6A 01 00 00 00 00 00 00} // OR
{6B 01 00 00 00 00 00 00} // XOR

If you toggle the R And, the LinkNoLink command still remains in the code even if you don't have it checked.

Right. Strange problem! I don't understand how it may be related to the operator! I'll try to fix that.