PgcEdit 0.5

[r0lZ]

Originally posted by 2COOL
Maybe some people would like to have the option to not see the hex values in the command pane?

This has been already asked. Unfortunately, I need the hex codes with the commands, because much of the edit buttons are working directly on the listbox contents. When another PGC is opened, the commands are saved back in memory, and I need the hex codes to retrieve them from the listbox.

[r0lZ]

Originally posted by selyb
Request: if i am in trace mode and i open a new dvd, i would like pgcedit to automatically exit trace mode

It's really easy to close it yourself, no?

Request: not sure if you can do this but, when i paste an illegal command, could you try to convert it?

what i run into often is when in the VMGM, i replace a command 'Jump to Title X" with all the commands located in Title X and those commands have "Call VMGM PGC X" and i have to manually convert each one to "Link PGC X"

That's not easy to do. However, I will try to verify the commands in a better way. Maybe I'll be able to add a conversion, too. But don't expect that soon. I have many other things on my TODO list.

[r0lZ]

Originally posted by selyb
Request:
when i have modified the dvd and i hit close, could you make it ask if i want to save before quitting and use a yes\no\cancel box

Also easy to do manually. Just click Cancel, and hit the Save icon.
But, as it's easy to do for me, I may add it...

@jeanl: selyb wants a save option integrated in the warning dialog.

[selyb]

Originally posted by selyb
Request:
when i have modified the dvd and i hit close, could you make it ask if i want to save before quitting and use a yes\no\cancel box

in pgcedit.tcl i changed

	if {$::dvd_modified && $code == 0 && !$::config(expert_mode)} {
		set r [tk_messageBox -message "The DVD has been modified.\n\nOK to quit?" \
				-icon warning -title "PgcEdit" -type yesno -default no]
		if {$r == "no"} return
	}

to

	if {$::dvd_modified && $code == 0 && !$::config(expert_mode)} {
		set r [tk_messageBox -message "The DVD has been modified.\n\nDo you want to save first?" \
				-icon warning -title "PgcEdit" -type yesnocancel -default yes]
		if {$r == "cancel"} return
		if {$r == "yes"} {::main::Write_DVD false}
	}

and in main.tcl and utils.tcl i changed

	if {$::dvd_modified && !$::config(expert_mode)} {
		set r [tk_messageBox -message "The DVD has been modified.\n\nAre you sure?" \
				-icon warning -title "PgcEdit" -type yesno -default no]
		if {$r == "no"} {return 0}
	}

to

	if {$::dvd_modified && !$::config(expert_mode)} {
		set r [tk_messageBox -message "The DVD has been modified.\n\nDo you want to save first?" \
				-icon warning -title "PgcEdit" -type yesnocancel -default yes]
		if {$r == "cancel"} {return 0}
		if {$r == "yes"} {::main::Write_DVD false}
	}

[selyb]

Originally posted by selyb
Request: if i am in trace mode and i open a new dvd, i would like pgcedit to automatically exit trace mode

in main.tcl i added

if {$::tr::tracemode} ::tr::dvd_trace

immediately after

proc Read_New_DVD {args} {

	if {$::dvd_modified && !$::config(expert_mode)} {
		set r [tk_messageBox -message "The DVD has been modified.\n\nDo you want to save first?" \
				-icon warning -title "PgcEdit" -type yesnocancel -default yes]
		if {$r == "cancel"} {return 0}
		if {$r == "yes"} {::main::Write_DVD false}
	}

	if {$args == ""} {
		unset -nocomplain ::tr::breakpoints	;# reset breakpoints of Trace mode
		set initialdir $::config(initialdir)
		while true {
			set dvddir [tk_chooseOldDirectory -initialdir $initialdir \
				-parent . -title "PgcEdit: Open DVD folder"]
			if {$dvddir == ""} return

and in trace.tcl i changed

	set ::tr::wm_main_window $w
	if {[winfo exists $w] && [winfo ismapped $w]} {
		cleanexit
		return
	}

to

	set ::tr::wm_main_window $w
	if {[winfo exists $w] && [winfo ismapped $w]} {
		cleanexit
		return
	} else {set ::tr::tracemode 1}

[jeanl]

selyb,
I think you're the first one to starting hacking into PgcEdit!
Amazing!
Jeanl

[r0lZ]

I have added some similar code in the new version, to save if needed before quitting/opening a new DVD. However, your method will ask to save the DVD if you reopen it. IMHO, it is not useful in this case.

Also, my method to open trace mode is identical to yours, except I have suggested to set the code in pgcedit.user.tcl (which is a post script opened automatically if it exists after the whole initialization was done) because it doesn't require to recreate the standalone exe.
Since this feature seems to be appreciated, I will add an option to automatically go to trace mode whan a DVD is opened, in the Options menu.

[selyb]

Originally posted by jeanl
selyb,
I think you're the first one to starting hacking into PgcEdit!
Amazing!
Jeanl

i wouldnt call editing an open source script 'hacking', but thanks for the props anyway

Originally posted by r0lZ
I have added some similar code in the new version, to save if needed before quitting/opening a new DVD. However, your method will ask to save the DVD if you reopen it. IMHO, it is not useful in this case.

i noticed this, i was in the process of trying to figure out how to change that

Originally posted by r0lZ

Also, my method to open trace mode is identical to yours, except I have suggested to set the code in pgcedit.user.tcl (which is a post script opened automatically if it exists after the whole initialization was done) because it doesn't require to recreate the standalone exe.
Since this feature seems to be appreciated, I will add an option to automatically go to trace mode whan a DVD is opened, in the Options menu.

what i added was to quit trace mode when opening a dvd, i understand what youre saying though

[r0lZ]

Originally posted by selyb
i noticed this, i was in the process of trying to figure out how to change that

In main.tcl, function ReRead_DVD, insert

dvd_modified false false

before the line

set errcode [Read_New_DVD $::dvddir]

or wait for the next version.

[selyb]

btw, the reason i added

set ::tr::wm_main_window $w
if {[winfo exists $w] && [winfo ismapped $w]} {
cleanexit
return
} else {set ::tr::tracemode 1}

in trace.tcl is because of a small cosmetic bug
if you use ctrl+t to open trace mode, the tracemode variable does not get set and the checkmark on the menu is not present

i found this out because i use that variable as a check to see if i need to call dvd_trace

[r0lZ]

Right. I have also added this variable assignment in the final version.

[selyb]

Originally posted by r0lZ
In main.tcl, function ReRead_DVD, insert

dvd_modified false false

before the line

set errcode [Read_New_DVD $::dvddir]

this would omit a dvd modified message entirely if you hit the reopen button wouldnt it?
maybe you could also add a message to 'proc ReRead_DVD' to ask "Are you sure you want to Reopen the DVD and lose all changes?"

[r0lZ]

That's what I did.

[r0lZ]

PgcEdit 0.5.7 beta 1 available.

It's not an important release. I've just made some cosmetics changes, including an option to hide the hex codes in the main window. Since this option was not easy to implement, I may have broken something. So, use this beta with care, and, if you experience some problems, please report them here. Thanks.

• A. Added an option to hide the [hex codes] in the main commands listbox.
• A. Added an option to go automatically to Trace mode whan a DVD is opened.
• E. The "DVD modified, are you sure?" warning now allow to save the DVD.
• F. Fixed a typo: changed all occurences of sheme to scheme.

As usual, the beta is in the 'All Versions' folder of the PgcEdit homepage at VideoHelp only.

[zacoz]

Originally posted by r0lZ
... cosmetics changes, including an option to hide the hex codes in the main window.

@r0lZ: You just can't resist a challenge can you.

I'd figured "Sheme/Scheme" had actually been shortened to fit on the button. While on the subject, the IFO File Association dialog box uses the word "overwrited". English grammar would dictate that "overwritten" would be correct.

[selyb]

Originally posted by r0lZ
PgcEdit 0.5.7 beta 1 available.

...
As usual, the beta is in the 'All Versions' folder of the PgcEdit homepage at VideoHelp only.

i dont see it

[r0lZ]

Right. My fault. I have moved the beta files in the right directory now.

@zacoz and everybody: BTW, if you find more english grammar/vocabulary errors in PgcEdit, please let me know.

[Surf]

One lil request r0lZ: implementing a BMP capture with choice of ntsc/pal, 4:3 or 16:9...TIA.

edit: ntsc/pal is irrelevant..is it?

[r0lZ]

The captured image is always in the original format of the VOB, without any modification or resizing. If your VOB is NTSC, you will capture a NTSC frame. Same for PAL.
Note that a 16:9 anamorphic image has exactly the same resolution as a 4:3 image. It is the responsability of the player to resize it. So, all images you will save with PgcEdit will be 4:3 images.

I will not change that. If you want to convert the image to another format, resize it with a paint program. You will be able to use the best antialiazing method for the current image.

[selyb]

Originally posted by r0lZ
@zacoz and everybody: BTW, if you find more english grammar/vocabulary errors in PgcEdit, please let me know.

Current- Store PgcEdit_backup in the DVDs root folder instead of VIDEO_TS
Suggested- Store backup folder in parent of VIDEO_TS folder

Current- Adjust Command Editor window size
Suggested- Auto-adjust Command Editor window to contents

Current- Tearoff menus?
Suggested- Allow Menu Tearoffs.

Current- Highlight Errors and GOTO Targets? (Don't Detect All ERRORS!)
Suggested- Hi-lite Errors and GOTO Targets? (Doesn't Detect All ERRORS!)

Current- Popup menus on right mouse button released?
Suggested- Popup menu when right mouse button released?
or Popup menu on right mouse button release?

Current- Automatically renumber GOTOs upon cmds insert/delete?
Suggested- Auto renumber GOTOs when cmds added/removed?

Current- Save Setups
Suggested- Save Settings