VobBlanker 2.0.0.2 released

[2COOL]

Originally Posted by jsoto

I do not know how to code a multiline tooltip. Currently I'm limited to only one row in a tooltip.

I know you are using C++ but it can be done. http://www.codeguru.com/Cpp/controls...cle.php/c4161/

Don't ask me about C++ because I'm more of VB6 kinda guy.

[jsoto]

For sure I knew it can be done... but it is not "simple", needs some "investigation". Thanks for the link, it will be useful.

jsoto

[jeanl]

Thanks for the link 2C00L, I've been looking at doing that too. Amazing how M$ makes it hard to do even the most basic things (like change color on a button, or multiline displays)...
Jeanl

[jsoto]

After some investigation, it has been really easy... BTW, I'm using the class CToolTipDialog (author H. Devos), taken from ReJig sources.

To allow multiple line Tooltip
It is enough to add

m_wndToolTip.SetMaxTipWidth(TOOLTIPWIDTH);

before

m_wndToolTip.RelayEvent(&msg);

in

BOOL CToolTipDialog::PreTranslateMessage(MSG *pMsg)

that's all.

BTW, I do not see the 80 char limitation pointed in the article...

jsoto

[blutach]

Thanks jsoto - I did look at the help file, but the options are increasing at a rapid rate and a good explanation in the help file and/or tooltips might come in handy.

Regards

[jsoto]

Hi all,

Here you can find a new beta, including an updated help file and the changelog

http://www.vcdhelp.com/~jsoto/temp/V...2010b6_exe.zip

please report back any bug...I'm going to release it in a few days.

jsoto

[CoNS]

Changelog Vers 2.0.1.0 (??-09-2005)
[...]
Added:  Option to copy color palette when replacing PGC.
Added:  Option to copy Audio/subs tables and status when replacing PGC.
[...]

[CirTap]

@jsoto: sorry for not responding any earlier, I was offline.
the resize problem was gone with b5 (which you probably know by now), it's been weired as it really only happened in the main window, not the others as you suspected ...
anyway, thanx for the update!!

Have fun,
CirTap

[Taelon]

@jsoto,

I recently encountered MFC errors that would crash VB when Previewing ILV cells in VobBlanker_2002, also tested with 2003b2 which would also crash. I thought perhaps the fault would be resolved in v201, but checking beta6 and it still will crash eventually. I've tried to document the errors specific to v201.

Testing v201 b6, could not generate MFC error when Previewing a variety of ILV cells after fresh system boot, but at program exit received Application Error popup notice (see below). Restarted VB, Previewed an ILV cell & closed Previewer ok, but the second time Preview button is pressed causes MFC error (see below) doesn't matter if it's the first or second PGC entry (ILV). This behavior is repeatable until the system has been rebooted, it always crashes 2nd time a Preview window is opened for an ILV title.

Event Type: Information
Event Source: Application Popup
Description:
Application popup: VobBlanker.exe - Application Error : The instruction at "0x73dd292e" referenced memory at "0xede07778". The memory could not be "read".

Event Source: Application Error
Description:
Faulting application vobblanker.exe, version 2.0.1.0, faulting module mfc42.dll, version 6.2.4131.0, fault address 0x00001110.

I should point out that I've only seen this problem with 1 DVD and when I processed it with v2002 I was still able to blank out the 2nd ILV PGC, and it worked fine. The crash only seems to occur when previewing, often when closing or opening the Preview window.

[r0lZ]

Have you tried to preview the same cells with PgcEdit's preview? PgcEdit uses the same preview library. So, this test could help identify if the problem comes from the preview engine, or from VobBlanker.

[jeanl]

I'm curious about this problem. I have seen 1 other instance where the preview code crashes (but not in vobblanker and not in pgcedit, because of the way these programs use the preview, I wouldn't expect them to crash, and I've never seen them crash - ever ).
jeanl

[Taelon]

rolz,
I just now tried it and PgcEdit didn't crash or show any errors at all. Then tried VB again and eventually got it to crash, restarted it and verified it would crash 2nd time Preview was opened again. Then went back to PgcEdit and couldn't get it to crash no matter how many times I opened and closed the Preview.

The other difference I notice is by watching the Processes in Task Man, PgcEdit opens a seperate PgcEditPreview.exe process when previewing, VB seems to do everything including the preview in One Process.

I'll try to gather a little more info on that and post it soon.

[r0lZ]

Originally Posted by Taelon

The other difference I notice is by watching the Processes in Task Man, PgcEdit opens a seperate PgcEditPreview.exe process when previewing, VB seems to do everything including the preview in One Process.

That's right. PgcEdit uses an external executable, called PgcEdit_preview.exe, stored in the 'bin' folder, and written by jeanl. So, PgcEdit should not crash, even if the Preview crashes. So, you should verify the behaviour of the preview window and process, not PgcEdit's main process.

[jsoto]

@Taelon
I've done a quick test with Alien1 and I was not able to crash VB...
Could you explain exacly what do you do in preview window?
Are you seeking with anyone of the scroll bars?
jsoto

[goonix]

@jsoto

If I replace a small cell with a big VOB, I get following log file:

Version 2.0.1.0 beta 6. Starting new process:


=========== STARTING VTS_01 ====================
VTS 01: Opening IFO
VTS 01: Processing VOB (Menus)
--------------MENU VOB PREPARING PHASE-
VTS 01: Cell Based Menu LU 01, PGC 01
     Replacing Cell # 1, VID/CID=01/01
--------------MENU VOB WRITING PHASE STARTED-
VTS 01: (CB) Replacing Cell VID/CID: 01/01
     WARNING: Number of Cells in replacing VOB higher than one. Continuing with same cell VID/CID
--------------MENU VOB WRITING FINISHED-
VTS 01: Cell data array filled (Menus)
VTS 01: Processing IFO (Menu)
     Looping into Menu PGCs and cells
     PGCN Pointer: Pointing Prev PGCN to itself in LU 1, PGC 1
     Building VTSM_C_ADT table
     Filling VTSM_VOBU_ADMAP table
VTS 01: Processing IFO (Ending and writting)
=========== VTS_01 FINISHED =====================

=========== STARTING VIDEO MANAGER ===========
VIDEO_TS: Opening IFO
VIDEO_TS: Processing IFO (Ending and writting)
=========== VIDEO MANAGER FINISHED ===========


Moving Files start
     Moving File: VTS_01_0.IFO
     Moving File: VTS_01_0.BUP
     Moving File: VTS_01_0.VOB
     Moving File: VIDEO_TS.IFO
     Moving File: VIDEO_TS.BUP

Adjusting sectors
   Done OK

PostCommands changed into Precommands in 0 PGCs of a total of 0

Finished. No Errors, 1 Warnings

If I try to open the processed DVD files again, VB crashes with an MFC application error.

If I open the processed files with PgcEdit v 0.6.1beta10, I get following error message:

Fatal error!
PgcEdit is trying to read data after the end of a table.
This means that a Lenght Of Table value is probably wrong.

After a mock strip and manual setting of the audio status of the menu (containing the replaced cell) with IfoEdit, I can open the DVD files in PgcEdit and with VB too. Then it works as expected.

Seems there is still a problem with adjusting the tables in this version.
If it can't be fixed, can you add a error message to the log file at least?

goonix

[Taelon]

@rolz,
I didn't notice any problems with the preview in PgcEdit, except the stuttering and pixelization as it jumps between the ILV cells. The only thing I noticed was that other process in TaskMan.

@jsoto,
To recreate the problem in VB201b, after a fresh boot I've had to use the upper scroll bar to seek, and open and close the previewer on several different cells, before it will crash. After it's crashed once, I can make it crash again without using the seek bar, by just opening a cell, playing for a while, closing preview, open another cell. However I think it crashed sooner with VB2002 & 2003, but I can't say for sure.

I've never had any trouble with VB previewing ILV cells before, I even asked blutach about it a couple days ago because I was so surprised that VB crashed, I knew you would be releasing a new version soon, in part because of the MFC problems with window sizing. But when I found the problem still existed in VB201b I figured I should let you know.

Perhaps someone else can verify the problem, the title that is causing the crash is 'In the Bedroom' R1.

I don't know if it would help but I have a program called 'process explorer' I've got a snapshot while previewing in VB and also immediately after the crash, it lists all the threads, mutants, keys etc.

[Taelon]

jsoto,

I may have narrowed down the problem a little, I can cause the crash with MFC Error in 7 steps, without ever actually playing the Preview.

1) Start VB, Browse to Input folder, select VIDEO_TS.IFO
a) Click OK on message box "There are at least one ILV Cell"

2) Select the VTS_02_*.VOB Title Set
3) Select PGC 02 Entry
4) Press Prev/Cut (I don't hit any other buttons in the Preview Window)
5) Close Preview window
6) Select PGC 01 Entry
7) Press Prev/Cut

Immediately occurs the * VB MFC Application error *

AppName: vobblanker.exe AppVer: 2.0.1.0 ModName: mfc42.dll
ModVer: 6.2.4131.0 Offset: 000011e6

[jsoto]

@goonix,
Err, you're right, The code to grow the IFO is only included in the titles domain.... I simply forgot to put it also in the menus domain, so, currently, if VTSM_VOBU_ADMAP table has to grow in sectors, unexpected results will happen.
I'll fix it.
@Taelon
Unable to reproduce... please check your PM

jsoto

[jsoto]

New beta:
http://www.vcdhelp.com/~jsoto/temp/V...2010b8_exe.zip

Changes from beta6:
- Main window coordinates and size automaticaly saved/loaded (blutach)
- Larger fonts in Log (blutach)
- Bugfix in deleting last cells of last VOBIDs (the procedure was not deleting the last VOB-IDs if all cells were unreferenced).
- Completely new code to recreate the tables VTS_C_ADT VTS_VOBU_ADMAP VTSM_C_ADT VTSM_VOBU_ADMAP . Now the code supports ADT tables growing (in fact, it can currently happen blanking reused cells) and menu tables growing

Please note because I've changed a lot of code (the last point) there is some risk to additional new bugs...

Still unable to reproduce preview crash, even using ILV Cells in the first cell of the PGC, as in Taelon DVD... Do anyone more experience this problem?
BTW, I'm using exactly the same version of MFC42.dll (6.2.4131.0)

jsoto

[jeanl]

For what it is worth (probably not much), a while back I wrote a C++ class that is able to read IFOs, and access various parts in them. The class is able to grow any table.
If anybody is interested in using that class, I'm quite willing to share it. This isn't the right forum for that kind of offer, but several previous posts seem to have been on the subject of growing IFO tables.
As for the preview bug, in my experience, this is the kind of bug that's extremely difficult to reproduce in another machine. But until jsoto (or someone else with debug capabilities) are able to reproduce it, it will be hard to solve.

Jsoto, here's an idea: why don't you send taelon a debug version? He will need debug versions of a number of mfc dlls (but that's not really a problem), but this will enable him to tell you at which line, in which module the preview crashes. This might be a good starting point (in particular, you'll be able to see whether it crashes in your code, or in mine!!! )
jeanl