mClean spatio/temporal denoiser v3.2 (01 March 2018)

[tormento]

Originally Posted by burfadel

Are you using the latest versions of all the plugins, for example MVTools2 (pfmod)? https://github.com/pinterf/mvtools/releases/

Yes and the video is Mod 16.

[Groucho2004]

Originally Posted by tormento

Yes and the video is Mod 16.

You could try running the script with AVSMeter. If that works, something else in the chain is not working as it should (avs2yuv?).

[burfadel]

The smallest blocksize that the script uses is 8. I tried it on a clip resolution of 524,288, and no hassles.

[tormento]

Originally Posted by Groucho2004

You could try running the script with AVSMeter. If that works, something else in the chain is not working as it should (avs2yuv?).

AVSMeter 2.6.0 (x64) - Copyright (c) 2012-2017, Groucho2004
AviSynth+ 0.1 (r2508, MT, x86_64) (0.1.0.0)

MAnalyse: Block sizes must be 8 or more for divide mode
(D:/Programmi/Media/AviSynth+/plugins64/mClean-1.9ùburfadel.avsi, line 109)
(E:\in\1_30 Eden Lake\eden_mclean.avs, line 13)

Same video works with SMDegrain, KNLMeansCL, FFT3D, etc etc etc

Isn't simply that a () without parameters triggers some strange bug?

My environment:

Log created with:           AVSMeter 2.6.0 (x64)

[OS/Hardware info]
Operating system:           Windows 10 (x64) (Build 17025)
CPU brand string:           Intel(R) Core(TM) i7-2600K CPU @ 3.40GHz
CPU features:               MMX, SSE, SSE2, SSE3, SSSE3, SSE4.1, SSE4.2, AVX, POPCNT, AES


[Avisynth info]
VersionString:              AviSynth+ 0.1 (r2508, MT, x86_64)
VersionNumber:              2.60
File / Product version:     0.1.0.0 / 0.1.0.0
Interface Version:          6
Multi-threading support:    Yes
Avisynth.dll location:      C:\WINDOWS\SYSTEM32\avisynth.dll
Avisynth.dll time stamp:    2017-06-29, 09:09:33 (UTC)
PluginDir2_5 (HKLM, x64):   D:\AviSynth+\plugins64
PluginDir+   (HKLM, x64):   D:\AviSynth+\plugins64+


[CPP 2.5 / 64 Bit Plugins]
D:\AviSynth+\plugins64\Dither-1.27.2.dll
D:\AviSynth+\plugins64\f3kdb-2.0•20140721—SAPikachu.dll

[CPP 2.6 / 64 Bit Plugins]
D:\AviSynth+\plugins64+\ConvertStacked.dll
D:\AviSynth+\plugins64+\DCTFilter-0.5.0—chikuzen.dll  [0.5.0.0]
D:\AviSynth+\plugins64+\DirectShowSource.dll
D:\AviSynth+\plugins64+\FFT3dFilter-2.4—pinterf.dll  [2.4.0.0]
D:\AviSynth+\plugins64+\ImageSeq.dll
D:\AviSynth+\plugins64+\KNLMeansCL-1.1.0.dll
D:\AviSynth+\plugins64+\MaskTools-2.2.10—pinterf.dll  [2.2.10.0]
D:\AviSynth+\plugins64+\MedianBlur2-0.94—tp7.dll
D:\AviSynth+\plugins64+\MVTools-2.7.2.23—pinterf.dll  [2.7.23.0]
D:\AviSynth+\plugins64+\RgTools-0.96—pinterf.dll  [0.96.0.0]
D:\AviSynth+\plugins64+\Shibatch.dll
D:\AviSynth+\plugins64+\TimeStretch.dll
D:\AviSynth+\plugins64+\VDubFilter.dll

[Scripts / AVSI]
D:\AviSynth+\plugins64+\colors_rgb.avsi
D:\AviSynth+\plugins64\CompTest.avsi
D:\AviSynth+\plugins64\DeHalo_alpha—realfinder.avsi
D:\AviSynth+\plugins64\Dither-1.27.2.avsi
D:\AviSynth+\plugins64\mClean-1.9—burfadel.avsi
D:\AviSynth+\plugins64\MT_xxpand_multi.avsi
D:\AviSynth+\plugins64\SMDegrain-3.1.2·93—realfinder.avsi
D:\AviSynth+\plugins64\VHSHaloremover.avsi

[Uncategorized / Other]
D:\AviSynth+\plugins64+\AviSynth-new.css
D:\AviSynth+\plugins64+\AviSynth.css
D:\AviSynth+\plugins64+\colors_rgb.txt
D:\AviSynth+\plugins64+\DCTFilter-0.5.0—chikuzen.md
D:\AviSynth+\plugins64+\FFT3dFilter-2.4—pinterf.gif
D:\AviSynth+\plugins64+\FFT3dFilter-2.4—pinterf.htm
D:\AviSynth+\plugins64+\FFT3dFilter-2.4—pinterf.txt
D:\AviSynth+\plugins64+\MaskTools-2.0a48.htm
D:\AviSynth+\plugins64+\MaskTools-2.2.10—pinterf.md
D:\AviSynth+\plugins64+\MedianBlur-0.84.txt
D:\AviSynth+\plugins64+\MVTools-2.7.2.22—pinterf.htm
D:\AviSynth+\plugins64+\MVTools-2.7.2.23—pinterf.md
D:\AviSynth+\plugins64+\RgTools-0.96—pinterf.md
D:\AviSynth+\plugins64\AviSynth-new.css
D:\AviSynth+\plugins64\AviSynth.css
D:\AviSynth+\plugins64\Dither-1.27.2.htm
D:\AviSynth+\plugins64\f3kdb-2.0•20140721—SAPikachu.html
D:\AviSynth+\plugins64\SMDegrain-3.1.2d.htm



[DLL dependencies (x64)]
C:\WINDOWS\SYSTEM32\avisynth.dll:
    AVIFIL32.dll
    MSVFW32.dll
    MSACM32.dll
    GDI32.dll
    USER32.dll
    ADVAPI32.dll
    ole32.dll
    imagehlp.dll
    MSVCP140.dll
    KERNEL32.dll
    VCRUNTIME140.dll
    api-ms-win-crt-runtime-l1-1-0.dll
    api-ms-win-crt-heap-l1-1-0.dll
    api-ms-win-crt-string-l1-1-0.dll
    api-ms-win-crt-stdio-l1-1-0.dll
    api-ms-win-crt-math-l1-1-0.dll
    api-ms-win-crt-environment-l1-1-0.dll
    api-ms-win-crt-filesystem-l1-1-0.dll
    api-ms-win-crt-locale-l1-1-0.dll
    api-ms-win-crt-utility-l1-1-0.dll
    api-ms-win-crt-convert-l1-1-0.dll
    api-ms-win-crt-time-l1-1-0.dll

D:\AviSynth+\plugins64\Dither-1.27.2.dll:
    KERNEL32.dll

D:\AviSynth+\plugins64\f3kdb-2.0•20140721—SAPikachu.dll:
    KERNEL32.dll

D:\AviSynth+\plugins64+\ConvertStacked.dll:
    KERNEL32.dll
    VCRUNTIME140.dll
    api-ms-win-crt-heap-l1-1-0.dll
    api-ms-win-crt-runtime-l1-1-0.dll

D:\AviSynth+\plugins64+\DCTFilter-0.5.0—chikuzen.dll:
    VCRUNTIME140.dll
    api-ms-win-crt-heap-l1-1-0.dll
    api-ms-win-crt-runtime-l1-1-0.dll
    KERNEL32.dll

D:\AviSynth+\plugins64+\DirectShowSource.dll:
    WINMM.dll
    QUARTZ.dll
    ole32.dll
    USER32.dll
    OLEAUT32.dll
    KERNEL32.dll
    VCRUNTIME140.dll
    api-ms-win-crt-string-l1-1-0.dll
    api-ms-win-crt-stdio-l1-1-0.dll
    api-ms-win-crt-runtime-l1-1-0.dll
    api-ms-win-crt-heap-l1-1-0.dll

D:\AviSynth+\plugins64+\FFT3dFilter-2.4—pinterf.dll:
    KERNEL32.dll
    USER32.dll
    VCRUNTIME140.dll
    api-ms-win-crt-heap-l1-1-0.dll
    api-ms-win-crt-runtime-l1-1-0.dll
    api-ms-win-crt-math-l1-1-0.dll

D:\AviSynth+\plugins64+\ImageSeq.dll:
    DevIL.dll
    MSVCP140.dll
    KERNEL32.dll
    VCRUNTIME140.dll
    api-ms-win-crt-runtime-l1-1-0.dll
    api-ms-win-crt-stdio-l1-1-0.dll
    api-ms-win-crt-filesystem-l1-1-0.dll
    api-ms-win-crt-heap-l1-1-0.dll

D:\AviSynth+\plugins64+\KNLMeansCL-1.1.0.dll:
    OpenCL.dll
    MSVCP140.dll
    KERNEL32.dll
    VCRUNTIME140.dll
    api-ms-win-crt-locale-l1-1-0.dll
    api-ms-win-crt-stdio-l1-1-0.dll
    api-ms-win-crt-runtime-l1-1-0.dll
    api-ms-win-crt-filesystem-l1-1-0.dll
    api-ms-win-crt-string-l1-1-0.dll
    api-ms-win-crt-heap-l1-1-0.dll

D:\AviSynth+\plugins64+\MaskTools-2.2.10—pinterf.dll:
    KERNEL32.dll
    MSVCP140.dll
    VCRUNTIME140.dll
    api-ms-win-crt-runtime-l1-1-0.dll
    api-ms-win-crt-heap-l1-1-0.dll
    api-ms-win-crt-convert-l1-1-0.dll
    api-ms-win-crt-string-l1-1-0.dll
    api-ms-win-crt-stdio-l1-1-0.dll
    api-ms-win-crt-math-l1-1-0.dll

D:\AviSynth+\plugins64+\MedianBlur2-0.94—tp7.dll:
    MSVCR110.dll
    KERNEL32.dll

D:\AviSynth+\plugins64+\MVTools-2.7.2.23—pinterf.dll:
    KERNEL32.dll
    MSVCP140.dll
    VCRUNTIME140.dll
    api-ms-win-crt-string-l1-1-0.dll
    api-ms-win-crt-runtime-l1-1-0.dll
    api-ms-win-crt-heap-l1-1-0.dll
    api-ms-win-crt-stdio-l1-1-0.dll
    api-ms-win-crt-math-l1-1-0.dll
    api-ms-win-crt-utility-l1-1-0.dll

D:\AviSynth+\plugins64+\RgTools-0.96—pinterf.dll:
    VCRUNTIME140.dll
    api-ms-win-crt-heap-l1-1-0.dll
    api-ms-win-crt-runtime-l1-1-0.dll
    KERNEL32.dll

D:\AviSynth+\plugins64+\Shibatch.dll:
    MSVCP140.dll
    KERNEL32.dll
    VCRUNTIME140.dll
    api-ms-win-crt-math-l1-1-0.dll
    api-ms-win-crt-heap-l1-1-0.dll
    api-ms-win-crt-runtime-l1-1-0.dll
    api-ms-win-crt-stdio-l1-1-0.dll

D:\AviSynth+\plugins64+\TimeStretch.dll:
    KERNEL32.dll
    VCRUNTIME140.dll
    api-ms-win-crt-math-l1-1-0.dll
    api-ms-win-crt-heap-l1-1-0.dll
    api-ms-win-crt-runtime-l1-1-0.dll

D:\AviSynth+\plugins64+\VDubFilter.dll:
    USER32.dll
    KERNEL32.dll
    VCRUNTIME140.dll
    api-ms-win-crt-stdio-l1-1-0.dll
    api-ms-win-crt-heap-l1-1-0.dll
    api-ms-win-crt-runtime-l1-1-0.dll

[External (plugin) functions]
D:\AviSynth+\plugins64\Dither-1.27.2.dll:
    DitherPost
    Dither_add16
    Dither_bilateral16
    Dither_box_filter16
    Dither_limit_dif16
    Dither_max_dif16
    Dither_median16
    Dither_merge16
    Dither_min_dif16
    Dither_out
    Dither_removegrain16
    Dither_repair16
    Dither_resize16
    Dither_sub16
    SmoothGrad

D:\AviSynth+\plugins64\f3kdb-2.0•20140721—SAPikachu.dll:
    f3kdb
    flash3kyuu_deband

D:\AviSynth+\plugins64+\ConvertStacked.dll:
    ConvertFromDoubleWidth
    ConvertFromStacked
    ConvertToDoubleWidth
    ConvertToStacked

D:\AviSynth+\plugins64+\DCTFilter-0.5.0—chikuzen.dll:
    DCTFilter
    DCTFilter4
    DCTFilter4D
    DCTFilter8
    DCTFilter8D
    DCTFilterD

D:\AviSynth+\plugins64+\DirectShowSource.dll:
    DirectShowSource

D:\AviSynth+\plugins64+\FFT3dFilter-2.4—pinterf.dll:
    FFT3DFilter
    FFT3DFilter_VersionNumber

D:\AviSynth+\plugins64+\ImageSeq.dll:
    ImageReader
    ImageSource
    ImageSourceAnim
    ImageWriter

D:\AviSynth+\plugins64+\KNLMeansCL-1.1.0.dll:
    KNLMeansCL

D:\AviSynth+\plugins64+\MaskTools-2.2.10—pinterf.dll:
    mt_adddiff
    mt_average
    mt_binarize
    mt_circle
    mt_clamp
    mt_convolution
    mt_deflate
    mt_diamond
    mt_edge
    mt_ellipse
    mt_expand
    mt_freeellipse
    mt_freelosange
    mt_freerectangle
    mt_gradient
    mt_hysteresis
    mt_infix
    mt_inflate
    mt_inpand
    mt_invert
    mt_logic
    mt_losange
    mt_lut
    mt_lutf
    mt_luts
    mt_lutspa
    mt_lutsx
    mt_lutxy
    mt_lutxyz
    mt_lutxyza
    mt_makediff
    mt_mappedblur
    mt_merge
    mt_motion
    mt_polish
    mt_rectangle
    mt_square

D:\AviSynth+\plugins64+\MedianBlur2-0.94—tp7.dll:
    MedianBlur
    MedianBlurTemporal

D:\AviSynth+\plugins64+\MVTools-2.7.2.23—pinterf.dll:
    MAnalyse
    MBlockFps
    MCompensate
    MDegrain1
    MDegrain2
    MDegrain3
    MDegrain4
    MDegrain5
    MDegrain6
    MDegrainN
    MDepan
    MFlow
    MFlowBlur
    MFlowFps
    MFlowInter
    MMask
    MRecalculate
    MRestoreVect
    MSCDetection
    MScaleVect
    MShow
    MStoreVect
    MSuper

D:\AviSynth+\plugins64+\RgTools-0.96—pinterf.dll:
    BackwardClense
    Clense
    ForwardClense
    RemoveGrain
    Repair
    VerticalCleaner

D:\AviSynth+\plugins64+\Shibatch.dll:
    SSRC
    SuperEQ

D:\AviSynth+\plugins64+\TimeStretch.dll:
    TimeStretch

D:\AviSynth+\plugins64+\VDubFilter.dll:
    LoadVirtualdubPlugin

[Groucho2004]

I get the same error.
Script:

colorbars(width = 1024, height = 1024, pixel_type = "yv12").killaudio().assumefps(50, 1).trim(0, 499)
mclean()

Also, with a resolution of 1024 x 1024, I get this error:

Script error: f3kdb does not have a named argument "preset"
(E:/Apps/VideoTools/AVSPlugins/AutoLoad/mclean.avsi, line 140)

Edit: It seems that the experimental f3kdb 2.0pre2 is required.

[tormento]

Originally Posted by Groucho2004

Edit: It seems that the experimental f3kdb 2.0pre2 is required.

I think your comment refers only to second error, as I already had the experimental version and the first error occurred.

[burfadel]

2.0.0.1 for f3kdb is basically the 'final'. Work stopped on it, source code is available on github. https://github.com/SAPikachu/flash3kyuu_deband/releases

The other error is a result of a fixing a syntax error. I'll fix it for version 2.0, which will be released shortly. That one will require the autoadjust plugin for one of the settings change, allowing for basically harmonising colour balance, deflicker etc (more appropriate custom settings). Yes, another plugin, but it's super fast and applied at the appropriate location. It's also much more effective than my attempt that I got working with scriptclip but was a little finnicky stability wise. Basically there are four deband settings, 0=disabled, 1=deband only, 2=auto balance only, 3=deband and auto balance. Deband 1 is the default (so the extra filter won't be required), unless non 8 bit where 0 is default (f3kdb limitation), with auto balance option 2 will be still available.

[Groucho2004]

Originally Posted by tormento

I think your comment refers only to second error

That's correct.

[Groucho2004]

Originally Posted by burfadel

2.0.0.1 for f3kdb is basically the 'final'. Work stopped on it, source code is available on github. https://github.com/SAPikachu/flash3kyuu_deband/releases

I have been using f3kdb 1.5.1 for years and it has served me well. I'm a bit reluctant to use the 2.0 version because of SAPikachu's "experimental" and "use with caution" notes in the first post of the f3kdb thread. Maybe I should give it a try...

[MysteryX]

Originally Posted by burfadel

2.0.0.1 for f3kdb is basically the 'final'. Work stopped on it, source code is available on github. https://github.com/SAPikachu/flash3kyuu_deband/releases

There's no pre-compiled version of it?

and it requires Python AND GCC to build!? I won't spent half an hour just to try to build something that should be ready to use.

[pinterf]

For divide error message: maybe the problem is that 8x8 block size becomes 4x4 for yv12 chroma. Try with yv24

[tebasuna51]

About the tormento error: MAnalyse: Block sizes must be 8 or more for divide mode
in line 109: MRecalculate(...MAnalyse(...blksize=blksizeL/sc...), blksize=blksize/sc)

Using the lines in v1.9 13:41, 31 Oct 2017:

defH     = Max (C.Height, C.Width/4*3) # always Width/4*3 for AR >= 4:3 (most the times)
blkSize  = Default (blkSize, defH >=2600 ? 32 : defH>1200 ? 16 : defH>480 ? 12 : 8)
sc       = defH >=2600 ? 8 : defH>1200 ? 4 : defH>480 ? 2 : 1
blksizeL = blksize>8<=16 ? 24 : blksize>16<=32 ? 32 : sc==8 ? 48 : 16

I obtain:

Width Range  blkSize  sc  blksize/sc  blksizeL  blksizeL/sc
-----------  -------  --  ----------  --------  -----------
<644            8     1       8        16         16
644-1603       12     2       6        24         12
1604-3467      24     4       6        24 (32)     6  (8)
>3467          32     8       4        24 (48)     3  (6)

Like you see blksizeL never ground from 24
maybe you need change this line:

blksizeL = sc==8 ? 48 : blksize>16 ? 32 :blksize>8 ? 24 : 16

with the new (values)

BTW the values passed to MRecalculate and MAnalyse can be less than 8...

[burfadel]

Updated first post with version 2.0.

[StainlessS]

burfadel,

blksizeL = blksize>8<=16 ? 24 : blksize>16<=32 ? 32 : sc==8 ? 48 : 16

I think you misunderstand how this bit "blksize>8<=16" works,
what that is saying is:- if blksize is greater than 8 AND if 8 is smaller or equal to 16 then ...

what I think you intend is this, " 8 < blksize <= 16 " or in non shorthand version " 8 < blksize && blksize <= 16 ".

The "blksize>16<=32" is likewise a little screwy I think.

[RieGo]

trying V2.0 with default settings i get an error:
f3kdb Initialization failed (code: 3). Invalid parameter sample_mode, must be between 1 and 2.
tested f3kdb 2.0 and the older one.

[burfadel]

Originally Posted by StainlessS

burfadel,

blksizeL = blksize>8<=16 ? 24 : blksize>16<=32 ? 32 : sc==8 ? 48 : 16

I think you misunderstand how this bit "blksize>8<=16" works,
what that is saying is:- if blksize is greater than 8 AND if 8 is smaller or equal to 16 then ...

what I think you intend is this, " 8 < blksize <= 16 " or in non shorthand version " 8 < blksize && blksize <= 16 ".

The "blksize>16<=32" is likewise a little screwy I think.

That makes sense . I'll change it for the next version.

Originally Posted by RieGo

trying V2.0 with default settings i get an error:
f3kdb Initialization failed (code: 3). Invalid parameter sample_mode, must be between 1 and 2.
tested f3kdb 2.0 and the older one.

That's weird. I've uploaded the version used here. It's the latest version (for now). 7-Zip archive.
https://1drv.ms/u/s!AmGuHbW3zvrBmb4tmBP2-KUToKUpVQ

[RieGo]

Originally Posted by burfadel

That's weird. I've uploaded the version used here. It's the latest version (for now). 7-Zip archive.
https://1drv.ms/u/s!AmGuHbW3zvrBmb4tmBP2-KUToKUpVQ

thanks, with this one it works... i guess i'll just use this one while i figure out my mistake

edit: i'm sorry it was my mistake. the version which i used before, thinking it's 1.x actually was 2.0
so it doesn't work with flash3kyuu 2.0. any chance you could add compatibility?

[StainlessS]

Originally Posted by burfadel

That makes sense . I'll change it for the next version.

I was not contradicting Tebasuna51 at all (was about to tumble into bed when I wrote it, and have not really tried to figure out what it should be). My only intent was that you were more informed about how that shortcut style condition works.

See Here:- https://forum.doom9.org/showthread.p...32#post1783132

[MysteryX]

This mClean thing is just teasing me. Compared to KnlMeansCL, I'm getting better results with mClean 1.3c with my 288p VCDs. On 1080p camera footage with noise, I get much better results with mClean 1.8 or 2.0 than with KnlMeansCL or SMDegrain. Then v1.8 and v2.0 give considerable distortion on SD sources, and all versions cause severe color distortions on some videos. Sometimes it works great, sometimes it works bad.

Then I can't easily adjust "enh" because it's default value is dynamic based on the video resolution, so if I want to increase or decrease by 10%, I have to look at the source, take my calculator, and determine the value from there.

I *want* to implement this within my video encoder, but for now it's too unreliable, so what am I supposed to do? I still get better results with either v1.3c or v1.8 on most sources. v2.0 seems to give a slightly more plastic effect, but also seems slightly closer to the original.

I guess the first step would be in properly identifying and diagnosing why the shape distortions and color distortions are happening in the first place.

[burfadel]

I'm currently time limited, but in early/mid December I should have some time to really sit down and work through those issues. As for the sharpening (old enh setting), I do have a solution but will require some time to balance it across all resolutions.