Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > Hardware & Software > Software players

Reply
 
Thread Tools Search this Thread Display Modes
Old 15th October 2015, 18:56   #33581  |  Link
Blackfyre
Registered User
 
Join Date: Dec 2014
Posts: 71
My apologies if this question has been asked before, but why has the "taps" feature been removed from "Jinc"..?

Anyway for anyone interested in my settings with a similar setup:

By the way the best settings I could do with a HD7970 (basically a 280X; exactly the same card) are:

Chroma Upscaling = Jinc (AR + SuperRes @ 2 passes)...
Image Doubling = NEDI for Luma + Chroma
Image Quadrupling = Super XBR Sharpness 100 for Luma + Chroma
Image Upscaling = Jinc (AR + LL)...
Upscaling Refinement = SuperRes (ticked enabled) and refine the image every ~2x upscaling step

As well as LumaSharpen (ticked enabled under processing - image enhancements section) with the Strength @ 0.30, Clamp @ 0.035, Radius @ 1.0

Smooth motion enabled and running in DX11 mode + FSE
CPU Queue size = 128
GPU Queue size = 12

trade quality for performance all ticked OFF

With my 4790K @ 4.7Ghz driving SVP @ 60FPS @ 1080P and using the HD4600 for GPU Acceleration with it, rather than my HD7970 which is solely dedicated to Madvr.
Blackfyre is offline   Reply With Quote
Old 15th October 2015, 21:19   #33582  |  Link
madshi
Registered Developer
 
Join Date: Sep 2006
Posts: 9,140
Quote:
Originally Posted by SecurityBunny View Post
The screen flashing is still occurring with v0.89.9, yes. Here are a few sample videos I took. Issue occurs with all builds between 0.89.7-0.89.9, testing was done on the latest.

MadVR v0.89.9
Flashing screen with smooth motion enabled. - Video Download
Flashing also occurs on normal dialogue subtitles that pop up at the bottom of the screen.

Flashing subtitles with smooth motion disabled. - Video Download

Big subtitles that sometimes don't retain the large size when skipping through the video. - Video Download

Big subtitles that go back to normal when skipping through a stylized karaoke opening. - Video Download

MadVR v0.89.6
No flashing subtitles or screen with smooth motion enabled. - Video Download

Normal sized subtitles. - Video Download
Thanks for the detailed report & videos!

Ouch. This flickering is exactly how it looked like in v0.89.7 and it was fixed for most users in v0.89.8. Do these flashes occur for you only when the first subtitle line appears? Or do they appear every time a subtitle line appears and goes away? Please try again with v0.89.10. If it still occurs, could you please create a debug log with v0.89.10 for me?

Quote:
Originally Posted by SecurityBunny View Post
I also ran into an issue where a few videos of mine, XySubFilter 3.1.0.744 does not display the subtitles while MPC-HC's internal subtitle renderer can. Here is one of my video files where this issue occurs. Video Download
Seems to work fine here with madVR v0.89.10.

Quote:
Originally Posted by ace960 View Post
I downloaded builds 0.88.6 and 0.88.5 for testing. Then I decided to test it again on 0.89.9. It works correctly (without the mpc-hc.exe compatibility setting). I really did not want to post non-existing problem. Thank you for your support.
No problem.

Quote:
Originally Posted by Blackfyre View Post
My apologies if this question has been asked before, but why has the "taps" feature been removed from "Jinc"..?
It was useless. More than 3 taps just wasted performance for no quality gain. So now 3 taps is forced.

Quote:
Originally Posted by Blackfyre View Post
Upscaling Refinement = SuperRes (ticked enabled) and refine the image every ~2x upscaling step
FWIW, SuperRes shows no noticeable quality difference if you refine the image after every ~2x upscaling step. So you can save performance by applying SuperRes only once.
madshi is offline   Reply With Quote
Old 15th October 2015, 21:21   #33583  |  Link
madshi
Registered Developer
 
Join Date: Sep 2006
Posts: 9,140
madVR v0.89.10 released

http://madshi.net/madVR.zip

Code:
* added SuperRes "sharpness" and "use linear light" options
* optimized SuperRes performance with high "strength" values
* modified subtitle mover to not change subtitle size, anymore
* added "zoom control" option to move subtitles
* added support for LAV DVD subtitle renderer
* fixed: XySubFilter: high-res PGS with smaller-res video: wrong sub position
* fixed: crash when LAV DVD subtitle renderer asked for a flush/clear
* fixed: Smooth Motion + NNEDI3 + Bilinear could cause aliasing artifacts
* fixed: #318: debanding sometimes caused black screen (once more)
XySubFilter users, please test madVR v0.89.10 with the new XySubFilter 745 build:

http://forum.doom9.org/showthread.php?t=168282
madshi is offline   Reply With Quote
Old 15th October 2015, 21:46   #33584  |  Link
aufkrawall
Registered User
 
Join Date: Dec 2011
Posts: 1,812
I really love the SuperRes changes.
Very nice for 1080p -> WQHD Jinc AR + SuperRes as a sharpener (e.g. sharpness 3 and linear light enabled to prevent brightness increase).

I'm perfectly happy with madVR now.
aufkrawall is offline   Reply With Quote
Old 15th October 2015, 21:56   #33585  |  Link
kasper93
MPC-HC Developer
 
Join Date: May 2010
Location: Poland
Posts: 591
madVR flashes frame from the future (probably last in the queue) on frame step. Not on every one, but very often. It looks like that Frame1->Flashes Frame (something from the queue)->Frame2 it is easily reproducible with MPC-HC and CTRL+left arrow to frame step. Seems to happen only with DX11. Here is log http://1drv.ms/1MswFTV
kasper93 is offline   Reply With Quote
Old 15th October 2015, 21:59   #33586  |  Link
SecurityBunny
Registered User
 
Join Date: Jul 2013
Posts: 76
Quote:
Originally Posted by madshi View Post
Thanks for the detailed report & videos!

Ouch. This flickering is exactly how it looked like in v0.89.7 and it was fixed for most users in v0.89.8. Do these flashes occur for you only when the first subtitle line appears? Or do they appear every time a subtitle line appears and goes away? Please try again with v0.89.10. If it still occurs, could you please create a debug log with v0.89.10 for me?
For me, the flashing was occurring on every subtitle line. Fortunately with v0.89.10 and XySubFilter 3.1.0.745, it seems the flashing only occurs on the first subtitle that occurs now instead of every line. And only when the video is played at a non-native aspect ratio / resolution of the file.

Here is a debug log of the flashing occurring.

Debug log - https://www.dropbox.com/s/hi8yiom7xc...20log.txt?dl=1

I started MPC-HC, swiped it to the side of my screen to lock it in place at half my resolution, started the video sample with the flashing subtitle at the beginning, paused the video, then closed down MPC-HC.

Besides the flashing that still occurs on the first subtitle that appears, all my other issues seem to be fixed, thanks. Had to disable move subtitles option as it was enabled by default when updating, but other than that, all good.
Quote:
Originally Posted by madshi View Post
Seems to work fine here with madVR v0.89.10.
Great! I can confirm subtitles now appear in that video sample with XySubFilter 3.1.0.745 and madVR v0.89.10.

Last edited by SecurityBunny; 15th October 2015 at 22:05.
SecurityBunny is offline   Reply With Quote
Old 15th October 2015, 22:07   #33587  |  Link
madshi
Registered Developer
 
Join Date: Sep 2006
Posts: 9,140
Quote:
Originally Posted by aufkrawall View Post
I really love the SuperRes changes.
Very nice for 1080p -> WQHD Jinc AR + SuperRes as a sharpener (e.g. sharpness 3 and linear light enabled to prevent brightness increase).

I'm perfectly happy with madVR now.
Glad to hear that!

Quote:
Originally Posted by kasper93 View Post
madVR flashes frame from the future (probably last in the queue) on frame step. Not on every one, but very often. It looks like that Frame1->Flashes Frame (something from the queue)->Frame2 it is easily reproducible with MPC-HC and CTRL+left arrow to frame step. Seems to happen only with DX11. Here is log http://1drv.ms/1MswFTV
Thanks. Will have a look at this later. Which GPU and OS?

Quote:
Originally Posted by SecurityBunny View Post
For me, the flashing was occurring on every subtitle line. Fortunately with v0.89.10 and XySubFilter 3.1.0.745, it seems the flashing only occurs on the first subtitle that occurs now instead of every line. And only when the video is played at a non-native aspect ratio / resolution of the file.

Here is a debug log of the flashing occurring.

Debug log - https://www.dropbox.com/s/hi8yiom7xc...20log.txt?dl=1

I started MPC-HC, swiped it to the side of my screen to lock it in place at half my resolution, started the video sample with the flashing subtitle at the beginning, paused the video, then closed down MPC-HC.

Besides the flashing that still occurs on the first subtitle that appears, all my other issues seem to be fixed, thanks. Had to disable move subtitles option as it was enabled by default when updating, but other than that, all good.
Thanks, will have a look later. JFMI: Why do you disable subtitle moving? Are both available options not to your liking?
madshi is offline   Reply With Quote
Old 15th October 2015, 22:07   #33588  |  Link
Arm3nian
Registered User
 
Join Date: Jul 2014
Location: Las Vegas
Posts: 177
Quote:
Originally Posted by madshi View Post
Are you using error diffusion? Try ordered or random dithering instead, if your GPU can't handle error diffusion with smooth motion + NNEDI3.
Quote:
Originally Posted by nevcairiel View Post
In any case, get rid of ED dithering, it eats a bunch of performance for an extremely minuscule gain - especially with Smooth Motion, as it has to dither every single output frame that SM generates. Use OD instead.
ED was all the rage a couple of months ago. People claimed IQ was dramatically improved. What changed? Is there no point with certain settings? Compared to OD, it lowers render times by 10ms with SM.

Subtitles aren't sharp at 4k. Can't you upscale? I don't see any options in XYSubFilter.
One more thing. On 150% Windows 10 scaling, the madVR setting's text is blurry. Any way to fix this?
Arm3nian is offline   Reply With Quote
Old 15th October 2015, 22:08   #33589  |  Link
madshi
Registered Developer
 
Join Date: Sep 2006
Posts: 9,140
madVR v0.89.11 released

http://madshi.net/madVR.zip

Code:
* fixed stupid video size bug introduced in v0.89.10
madshi is offline   Reply With Quote
Old 15th October 2015, 22:09   #33590  |  Link
kasper93
MPC-HC Developer
 
Join Date: May 2010
Location: Poland
Posts: 591
Quote:
Originally Posted by madshi View Post
Thanks. Will have a look at this later. Which GPU and OS?
R9 390, Windows 10
kasper93 is offline   Reply With Quote
Old 15th October 2015, 22:10   #33591  |  Link
sneaker_ger
Registered User
 
Join Date: Dec 2002
Posts: 5,565
Quote:
Originally Posted by madshi View Post
madVR v0.89.10 released
Code:
* added "zoom control" option to move subtitles
I see it's possible to do without activating black border detection. Shouldn't the "always shift the image" be possible without that as well?
sneaker_ger is offline   Reply With Quote
Old 15th October 2015, 22:13   #33592  |  Link
nevcairiel
Registered Developer
 
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,380
Quote:
Originally Posted by Arm3nian View Post
ED was all the rage a couple of months ago. People claimed IQ was dramatically improved. What changed? Is there no point with certain settings? Compared to OD, it lowers render times by 10ms with SM.
If any kind of dithering is "all the rage" and "IQ dramatically improved", then either the previous dithering was faulty, or people are massively over exaggerating.

IIRC, when ED was initially introduced, the only other option was the old random dithering, and from what I remember, I think it was one notch too strong (because it was modeled after audio dithering, which is stronger), so in that comparsion ED might have given a bigger impact. But later madshi added OD as well, and the difference between ED and OD wouldn't be that huge anymore.
__________________
LAV Filters - open source ffmpeg based media splitter and decoders
nevcairiel is offline   Reply With Quote
Old 15th October 2015, 22:18   #33593  |  Link
madshi
Registered Developer
 
Join Date: Sep 2006
Posts: 9,140
Quote:
Originally Posted by Arm3nian View Post
ED was all the rage a couple of months ago. People claimed IQ was dramatically improved. What changed? Is there no point with certain settings?
ED is nice, if you have GPU power to spare. But if you're short on GPU power, disabling ED and using the power you have for other processing algorithms can often be a good idea. ED is costly especially in combination with smooth motion FRC.

Quote:
Originally Posted by Arm3nian View Post
Subtitles aren't sharp at 4k. Can't you upscale? I don't see any options in XYSubFilter.
What kind of subtitles? PGS/SUP? SRT? ASS?

Quote:
Originally Posted by Arm3nian View Post
One more thing. On 150% Windows 10 scaling, the madVR setting's text is blurry. Any way to fix this?
Sure there are ways to fix it. But this falls under very very very very minor cosmetical issue, and as such is less important than pretty much everything else I still have on my to do list.

Quote:
Originally Posted by sneaker_ger View Post
I see it's possible to do without activating black border detection. Shouldn't the "always shift the image" be possible without that as well?
Well, I suppose it would be possible to do that. But would it actually be useful for you?
madshi is offline   Reply With Quote
Old 15th October 2015, 22:18   #33594  |  Link
nevcairiel
Registered Developer
 
Join Date: Mar 2010
Location: Hamburg/Germany
Posts: 10,380
Quote:
Originally Posted by madshi View Post
Code:
* added support for LAV DVD subtitle renderer
Just as a piece of information, to make use of this you'll need the latest LAV Filters nightly build, which will be available in about 6 hours.
This will then allow DVD menus and subtitles to be transmitted directly to madVR, which will allow madVR to move DVD subs into black bars, as well as reduce the delay when interacting with DVD menus, so its a win-win right here!
__________________
LAV Filters - open source ffmpeg based media splitter and decoders
nevcairiel is offline   Reply With Quote
Old 15th October 2015, 22:19   #33595  |  Link
SecurityBunny
Registered User
 
Join Date: Jul 2013
Posts: 76
Quote:
Originally Posted by madshi View Post
JFMI: Why do you disable subtitle moving? Are both available options not to your liking?
Personal preference I suppose. I prefer subtitles in the default location instead of having to look at the bottom of the video or in the black bar area if it exists. Also, stylized subtitle dialogue doesn't seem to move, at least from some of the video samples I tested. So for consistency sake, I'd prefer to keep everything in the standard location.

Last edited by SecurityBunny; 15th October 2015 at 22:23.
SecurityBunny is offline   Reply With Quote
Old 15th October 2015, 22:20   #33596  |  Link
madshi
Registered Developer
 
Join Date: Sep 2006
Posts: 9,140
Quote:
Originally Posted by nevcairiel View Post
Just as a piece of information, to make use of this you'll need the latest LAV Filters nightly build, which will be available in about 6 hours.
This will then allow DVD menus and subtitles to be transmitted directly to madVR, which will allow madVR to move DVD subs into black bars, as well as reduce the delay when interacting with DVD menus, so its a win-win right here!
Yep - and thank you very much for implementing this in LAV!
madshi is offline   Reply With Quote
Old 15th October 2015, 22:26   #33597  |  Link
sneaker_ger
Registered User
 
Join Date: Dec 2002
Posts: 5,565
Quote:
Originally Posted by madshi View Post
Well, I suppose it would be possible to do that. But would it actually be useful for you?
Not right now, it just came to my mind when I looked at the options. Would only be useful for people who don't want to deal with the black bar detection (e.g. because they already cropped during encoding).
sneaker_ger is offline   Reply With Quote
Old 15th October 2015, 22:35   #33598  |  Link
madshi
Registered Developer
 
Join Date: Sep 2006
Posts: 9,140
Quote:
Originally Posted by SecurityBunny View Post
Personal preference I suppose. I prefer subtitles in the default location instead of having to look at the bottom of the video or in the black bar area if it exists. Also, stylized subtitle dialogue doesn't seem to move, at least from some of the video samples I tested. So for consistency sake, I'd prefer to keep everything in the standard location.
Ok. In some situations the default location might be ok. But often it is not. E.g. look here, playing a DVD (using an LAV test build with the new LAV DVD subtitle export to madVR) with MPC-HC with the "notify media player" zoom control option activated:

default position - | - move up = down

Or here with the "notify media player" zoom control option deactivated:

default position - | - move up - | - move down

Isn't any of the move options always better (in this example at least)? I think having one subtitle line in the active video area and one subtitle line in the black bar is rather bad, and it happens quite often with the standard location.
madshi is offline   Reply With Quote
Old 15th October 2015, 22:55   #33599  |  Link
Asmodian
Registered User
 
Join Date: Feb 2002
Location: San Jose, California
Posts: 4,461
Quote:
Originally Posted by Arm3nian View Post
ED was all the rage a couple of months ago. People claimed IQ was dramatically improved. What changed? Is there no point with certain settings? Compared to OD, it lowers render times by 10ms with SM.
As nevcairiel already mentioned the excitement about ED dithering was before ordered dithering was added.

Comparing ordered dithering to ED dithering is much less significant than random to ED. I would probably have had a different opinion about whether two ED dithering options were necessary if ordered dithering had been available then (ordered dithering could replace ED2 without it bothering me).
__________________
madVR options explained
Asmodian is offline   Reply With Quote
Old 15th October 2015, 23:07   #33600  |  Link
Arm3nian
Registered User
 
Join Date: Jul 2014
Location: Las Vegas
Posts: 177
Quote:
Originally Posted by madshi View Post
What kind of subtitles? PGS/SUP? SRT? ASS?
.ASS looks good. PGS from a bluray is blurry. It's not even the same font as the .ASS. But the filters say xy->madVR.
Quote:
Originally Posted by madshi View Post
Sure there are ways to fix it. But this falls under very very very very minor cosmetical issue, and as such is less important than pretty much everything else I still have on my to do list.
I thought this would be a trivial fix. MPCBE, lav and xy seem to scale fine.

At first the move subtitles wasn't working for me. Then it started to work. But it messes up when scrubbing through the video. With my .ASS sample it starts at the bottom if I have it selected, but if I scrub a bit then it goes higher up.

Screenshots: initially

after scrubbing
Arm3nian is offline   Reply With Quote
Reply

Tags
direct compute, dithering, error diffusion, madvr, ngu, nnedi3, quality, renderer, scaling, uhd upscaling, upsampling

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 21:36.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2025, vBulletin Solutions Inc.