Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion.

Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules.

 

Go Back   Doom9's Forum > General > Audio encoding

Reply
 
Thread Tools Search this Thread Display Modes
Old 27th January 2012, 19:46   #221  |  Link
amtm
Guest
 
Posts: n/a
I forgot the change the parameter checking code. Can you post the file that crashes? I've tried the -info switch with a random assortment of samples hosted by mplayer and got no crashes.

Last edited by amtm; 27th January 2012 at 19:53.
  Reply With Quote
Old 27th January 2012, 19:56   #222  |  Link
phate89
Registered User
 
Join Date: Apr 2009
Posts: 153
Quote:
Originally Posted by amtm View Post
I forgot the change the parameter checking code. Can you post the file that crashes? I've tried the -info switch with a random assortment of samples hosted by mplayer and got no crashes.
no i confused -info with a sort of help switch that output all the switches (that could be an useful switch).. so i don't pass any input file.. that's the reason of the crash
phate89 is offline   Reply With Quote
Old 27th January 2012, 19:59   #223  |  Link
amtm
Guest
 
Posts: n/a
Yeah, -info has always been to just have it dump the info about the file. I'll look into why it crashes though.

Edit: I see the problem. Pushed the fix. Will post a new build tonight.

Additional edit: I'll put in a -help switch as well. Forgot to do that.

Last edited by amtm; 27th January 2012 at 20:04.
  Reply With Quote
Old 27th January 2012, 20:04   #224  |  Link
phate89
Registered User
 
Join Date: Apr 2009
Posts: 153
Quote:
Originally Posted by amtm View Post
Yeah, -info has always been to just have it dump the info about the file. I'll look into why it crashes though.

Edit: I see the problem. Pushed the fix. Will post a new build tonight.
yes i never used it... but maybe an -help that prompts all the switches without do anything and without the need of opening the readme file could be useful now that i think of...
phate89 is offline   Reply With Quote
Old 27th January 2012, 20:05   #225  |  Link
amtm
Guest
 
Posts: n/a
Yeah, I'll put one in. It was meant to be put in but it was just overlooked.
  Reply With Quote
Old 28th January 2012, 04:37   #226  |  Link
amtm
Guest
 
Posts: n/a
Ok. This now has all the fixes and implements the -help switch.
  Reply With Quote
Old 28th January 2012, 09:42   #227  |  Link
Selur
Registered User
 
Selur's Avatar
 
Join Date: Oct 2001
Location: Germany
Posts: 5,263
as a side note: remember to update the version info from time to time
__________________
Hybrid here in the forum, homepage
Selur is offline   Reply With Quote
Old 28th January 2012, 15:12   #228  |  Link
amtm
Guest
 
Posts: n/a
I will when I push out the real release.
  Reply With Quote
Old 28th January 2012, 15:17   #229  |  Link
Selur
Registered User
 
Selur's Avatar
 
Join Date: Oct 2001
Location: Germany
Posts: 5,263
okay
__________________
Hybrid here in the forum, homepage
Selur is offline   Reply With Quote
Old 29th January 2012, 17:05   #230  |  Link
amtm
Guest
 
Posts: n/a
New version here. Fixes CLI argument parsing, adds audio frame cut/delay support, adds -help switch and a few additional bug fixes.

Last edited by amtm; 30th January 2012 at 00:23.
  Reply With Quote
Old 29th January 2012, 18:48   #231  |  Link
Thunderbolt8
Registered User
 
Join Date: Sep 2006
Posts: 2,144
might be in here somewhere but cant find it atm, so I have to ask: is DTS-HD MA also supported or only normal DTS files? (if so, would it be possible to add filetype recognition for .dtsma .dtshr .dtshd, those are the most common ones when using eac3to, so you dont have to rename the file in order to load it with delaycut).

from what it seems, duration time is quite off when loading such a file (maybe also when being multichannel at the same time?)

v .7 also still has 1.4.3.6 in the title and as unzip path btw.
__________________
Laptop Acer Aspire V3-772g: i7-4202MQ, 8GB Ram, NVIDIA GTX 760M (+ Intel HD 4600), Windows 8.1 x64, madVR (x64), MPC-HC (x64), LAV Filter (x64), XySubfilter (x64)

Last edited by Thunderbolt8; 29th January 2012 at 19:03.
Thunderbolt8 is offline   Reply With Quote
Old 29th January 2012, 21:59   #232  |  Link
amtm
Guest
 
Posts: n/a
DTS-HD MA is still not supported yet. It is coming though. Also, the version number is correctly 1.4.3.6. Are you confusing the .7z from the archive extension?
  Reply With Quote
Old 29th January 2012, 22:02   #233  |  Link
Selur
Registered User
 
Selur's Avatar
 
Join Date: Oct 2001
Location: Germany
Posts: 5,263
Quote:
DTS-HD MA is still not supported yet. It is coming though.
Nice! (after that trueHD would be cool )
__________________
Hybrid here in the forum, homepage
Selur is offline   Reply With Quote
Old 29th January 2012, 22:41   #234  |  Link
Thunderbolt8
Registered User
 
Join Date: Sep 2006
Posts: 2,144
Quote:
Originally Posted by amtm View Post
DTS-HD MA is still not supported yet. It is coming though. Also, the version number is correctly 1.4.3.6. Are you confusing the .7z from the archive extension?
maybe, oops
__________________
Laptop Acer Aspire V3-772g: i7-4202MQ, 8GB Ram, NVIDIA GTX 760M (+ Intel HD 4600), Windows 8.1 x64, madVR (x64), MPC-HC (x64), LAV Filter (x64), XySubfilter (x64)
Thunderbolt8 is offline   Reply With Quote
Old 2nd February 2012, 15:09   #235  |  Link
kypec
User of free A/V tools
 
kypec's Avatar
 
Join Date: Jul 2006
Location: SK
Posts: 806
Quote:
Originally Posted by amtm View Post
New version here. Fixes CLI argument parsing, adds audio frame cut/delay support, adds -help switch and a few additional bug fixes.
Well, I really don't know what I'm doing wrong but this version 1.4.3.6 is giving me nothing but error messages:
Code:
delaycut -inputtype seconds -startcut 0 -cutend 6318.648 -i test.ac3
No valid input type specified.

Code:
delaycut -startcut 0 -cutEnd 6318648 -i test.ac3
Unrecognized switch: -cutend.

Code:
delaycut -startcut 0 -endsplit 6318648 -i test.ac3
Unrecognized switch: -endsplit.

Here is info on my test AC3 file (demuxed directly from DVD "Anne of Green Gables - Sequel" DISC SIDE A)
Code:
General
Complete name                    : D:\Source\test\test.ac3
Format                           : AC-3
Format/Info                      : Audio Coding 3
File size                        : 145 MiB
Duration                         : 1h 45mn
Overall bit rate mode            : Constant
Overall bit rate                 : 192 Kbps

Audio
Format                           : AC-3
Format/Info                      : Audio Coding 3
Mode extension                   : CM (complete main)
Duration                         : 1h 45mn
Bit rate mode                    : Constant
Bit rate                         : 192 Kbps
Channel(s)                       : 2 channels
Channel positions                : Front: L R
Sampling rate                    : 48.0 KHz
Bit depth                        : 16 bits
Compression mode                 : Lossy
Stream size                      : 145 MiB (100%)
Luckily GUI did work though it exhibits some funky behaviour when you check/uncheck Cut checkbox with already inserted value in seconds --> target info values seem to be recalculated as if the input type was still milliseconds. It's only a cosmetic bug AFAIK, once you click PROCESS the output file is correctly generated despite the info showing too short duration.
kypec is offline   Reply With Quote
Old 2nd February 2012, 15:26   #236  |  Link
amtm
Guest
 
Posts: n/a
Quote:
Originally Posted by kypec View Post
Well, I really don't know what I'm doing wrong but this version 1.4.3.6 is giving me nothing but error messages:
Code:
delaycut -inputtype seconds -startcut 0 -cutend 6318.648 -i test.ac3
No valid input type specified.
I see the bug. It's a logic problem in checking the valid types.

Quote:
Originally Posted by kypec View Post
Code:
delaycut -startcut 0 -cutEnd 6318648 -i test.ac3
Unrecognized switch: -cutend.
It's endcut not cutEnd. Seems I forgot to update the README for that one switch.

Quote:
Originally Posted by kypec View Post
Code:
delaycut -startcut 0 -endsplit 6318648 -i test.ac3
Unrecognized switch: -endsplit.
endsplit is not a valid switch. It's endcut.

Quote:
Originally Posted by kypec View Post
Here is info on my test AC3 file (demuxed directly from DVD "Anne of Green Gables - Sequel" DISC SIDE A)
Code:
General
Complete name                    : D:\Source\test\test.ac3
Format                           : AC-3
Format/Info                      : Audio Coding 3
File size                        : 145 MiB
Duration                         : 1h 45mn
Overall bit rate mode            : Constant
Overall bit rate                 : 192 Kbps

Audio
Format                           : AC-3
Format/Info                      : Audio Coding 3
Mode extension                   : CM (complete main)
Duration                         : 1h 45mn
Bit rate mode                    : Constant
Bit rate                         : 192 Kbps
Channel(s)                       : 2 channels
Channel positions                : Front: L R
Sampling rate                    : 48.0 KHz
Bit depth                        : 16 bits
Compression mode                 : Lossy
Stream size                      : 145 MiB (100%)
Luckily GUI did work though it exhibits some funky behaviour when you check/uncheck Cut checkbox with already inserted value in seconds --> target info values seem to be recalculated as if the input type was still milliseconds. It's only a cosmetic bug AFAIK, once you click PROCESS the output file is correctly generated despite the info showing too short duration.
I'm not following what you mean. What does the target info say and what do you expect it to say? When I set input type to seconds and input seconds in the cut field when I check and uncheck it is calculating it exactly right. And yes, internally it is translating your values into milliseconds when calculating the target info, but that should in no way cause durations to look different.

I've updated the CLI info on the main page since I had missed a few switches to rename.

Last edited by amtm; 2nd February 2012 at 15:40.
  Reply With Quote
Old 2nd February 2012, 15:53   #237  |  Link
amtm
Guest
 
Posts: n/a
New version here. Fixed the logic bug, updated the README and the output of -help to the properly named switches.

Last edited by amtm; 2nd February 2012 at 17:09.
  Reply With Quote
Old 3rd February 2012, 07:48   #238  |  Link
kypec
User of free A/V tools
 
kypec's Avatar
 
Join Date: Jul 2006
Location: SK
Posts: 806
Quote:
Originally Posted by amtm View Post
New version here. Fixed the logic bug, updated the README and the output of -help to the properly named switches.
a lot but...
  1. you forgot to update -version number in CLI, it still shows 1.4.3.6
  2. you forgot to update README section where CLI switches are explained (not Examples), there's still -cutEnd mentioned
  3. funky behaviour with check/uncheck toggling that I've been experiencing yesterday is now gone, strange...
Anyway, your prompt support and bug fixing is outstanding, much appreciated!
kypec is offline   Reply With Quote
Old 3rd February 2012, 15:22   #239  |  Link
amtm
Guest
 
Posts: n/a
Yeah missed those two. I did manage to fix it on the front page of this thread, in output of the -help switch, and even in the examples themselves yet missed it in one place in the README. Argh... I've fixed them both and I now set the version string in one place in the code so there should be no more issues with them being out of sync. I've got most of the new cutting and delaying behavior implemented (along with cutting within the file and inserting silence within the file) and will try to get in a fix for inserting silence for DTS core tracks extracted from DTS-HD MA tracks in the next release in a day or so.

And just so everyone knows the new cut/delay behavior works as follows:

If a delay is set in the filename, set from something like DGIndex, etc, and the delay is positive it will be set in the delay field and this will insert silence. If it's negative it will be treated as a cut value, since that's really what negative delay is doing, and will be added to the start cut and the cut checkbox will be checked. If both cut values and delay, I'm actually thinking of renaming it to "insert silence" since that's what it will really be doing from now on, values are specified the cutting will be done first and then the silence frames will be added at the specified points. That is unless silence will be added within the file and that will be done before cutting so that there is less chance for error prone translation to the position within the newly cut file.

Anyone have any issues or object with this new behavior?
  Reply With Quote
Old 3rd February 2012, 15:37   #240  |  Link
Selur
Registered User
 
Selur's Avatar
 
Join Date: Oct 2001
Location: Germany
Posts: 5,263
Quote:
If a delay is set in the filename, set from something like DGIndex, etc,...
Is this only for the GUI or also for the command line? (I prefer to set delay&co manually there)
+ What will happen if I call '-startdelay' with a negative value?
__________________
Hybrid here in the forum, homepage

Last edited by Selur; 3rd February 2012 at 15:43.
Selur is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 17:20.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2017, vBulletin Solutions Inc.