AddGrainC (now with Chroma noise & YUY2, RGB) - Page 3

leeperry · 28th May 2010, 17:09

it looks to me that the 3 grain layers in GrainF3 w/ 1.4 are not random anymore...they all seem to use the same pattern(except for the chunk size). w/ 1.1 I do get my "Grain EE 3D pop effect" feeling I've spent so much time working on...making halo-based EE is so yesterday

leeperry · 2nd June 2010, 03:47

..which makes me think that "seed repeatable" implies that provided I would find a "best" combination, I might be able to modify GrainF3 to always use the very same seeds/patterns....interesting!

leeperry · 5th June 2010, 00:34

BTW:

Quote:

seed (-1)
Specifies a repeatable grain sequence. Set to at least 0 to use.

constant (false)
Specifies a constant grain pattern on every frame.

at least 0? so this will set the grain sequence? what's the max? I'm not sure how to take advantage of the "repeatable seed" feature of 1.4

foxyshadis · 5th June 2010, 04:17

The max is probably either 2 billion or 4 billion, I forget. Any number will work about as well as any other. Every one will give you a different sequence of grain, but it'll always be identical for the same source parameters. Different colorspace or size will change everything. Give it a shot, set seed to something and keep reloading the script on different frames.

leeperry · 5th June 2010, 05:08

ok, interesting...this could do exactly what I want.

EDIT: and it does! many

TurboPascal7 · 26th October 2010, 08:02

Looks like a bug here. Bug appears with uvar > 0 and constant=true.
Example:

Right down corner. Seems to work incorrect on any resolution on yv12.

SSH4 · 25th November 2010, 15:47

hmm, i have some bug

AlekseiV · 26th November 2010, 06:02

Quote:

Originally Posted by SSH4

hmm, i have some bug

drink lots of orange juice

Reino · 26th October 2011, 20:46

Quote:

Originally Posted by foxyshadis

...it may also be SSE2 only (haven't run it on the Athlon yet).

I have and your filter doesn't work an my AMD Athlon XP 3200+.
For MCTemporalDenoise your filter is required, but here it comes down with this error:

Code:

Evaluate: System exception - Illegal Instruction
(GradFun2DBmod.v1.5.avsi, line 291)

GradFun2DBmod.v1.5.avsi:

Code:

290 grain  = custom=="empty" ? dither.addgrainC(str,strC,0,0)
291 \      :                   Eval("dither." + custom)
292 diff   = custom=="empty" ? blankclip(dither,color_yuv=$808080).addgrainC(str,strC,0,0)
293 \      :                   Eval("blankclip(dither,color_yuv=$808080)." + custom)

Removing the AddGrainC calls makes MCTemporalDenoise work, so I guess a SSE cpu, as mentioned in the readme, is not enough and your filter is actually SSE2 only at the moment.
If you find some time, could you please have a look?

cretindesalpes · 26th October 2011, 22:08

Quote:

Originally Posted by CoRoNe

I have and your filter doesn't work an my AMD Athlon XP 3200+.

Does this version work better?

EDIT: Link now points to v1.5.3 instead of 1.5.2, I also fixed a bug occurring with RGB24 colorspace, causing unwanted coloration.

Reino · 27th October 2011, 00:20

Wow, that's quick! Thanks a lot cretindesalpes. It works like a charm.

kypec · 27th October 2011, 05:27

Quote:

Originally Posted by cretindesalpes

EDIT: Link now points to v1.5.3 instead of 1.5.2, I also fixed a bug occurring with RGB24 colorspace, causing unwanted coloration.

You might want to update "AddGrain.txt" version history section with that fix as well.

SSH4 · 27th October 2011, 12:26

cretindesalpes can you check bug from TurboPascal7 post http://forum.doom9.org/showpost.php?...6&postcount=46 ?

cretindesalpes · 27th October 2011, 20:54

Quote:

Originally Posted by SSH4

cretindesalpes can you check bug from TurboPascal7 post http://forum.doom9.org/showpost.php?...6&postcount=46 ?

AddGrainC 1.5.4 fixes this problem, as well as other minor issues.

LaTo · 28th October 2011, 21:05

I took some minutes to add SSE2 code, now it's about 50% faster.
To turn off SSE2 and return to MMX set "sse2=false".

Here is the new version: AddGrainC 1.6.0

LaTo · 29th October 2011, 11:29

Just a one line update to add automatic switch to MMX if your cpu doesn't support SSE2.

Here: AddGrainC 1.6.1

leeperry · 3rd November 2011, 17:07

Quote:

Originally Posted by LaTo

I took some minutes to add SSE2 code, now it's about 50% faster.
To turn off SSE2 and return to MMX set "sse2=false".

Here is the new version: AddGrainC 1.6.0

awesomeness,

cretindesalpes · 16th August 2012, 00:29

AddGrainC 1.7.0

This version supports the new Avisynth 2.6 colorspaces: Y8, YV16, YV24 and YV411.

Overdrive80 · 16th August 2012, 01:21

Thanks very much for your effort

Reel.Deel · 16th August 2012, 01:44

Quote:

Originally Posted by cretindesalpes

AddGrainC 1.7.0

This version supports the new Avisynth 2.6 colorspaces: Y8, YV16, YV24 and YV411.

Wow cretindesalpes, your on a roll! Kudos to you.

Any future plans for the lsb in/out parameters?

28th May 2010, 17:09	#41 \| Link
leeperry Kid for Today Join Date: Aug 2004 Posts: 3,477	it looks to me that the 3 grain layers in GrainF3 w/ 1.4 are not random anymore...they all seem to use the same pattern(except for the chunk size). w/ 1.1 I do get my "Grain EE 3D pop effect" feeling I've spent so much time working on...making halo-based EE is so yesterday Last edited by leeperry; 28th May 2010 at 17:49.

5th June 2010, 05:08	#45 \| Link
leeperry Kid for Today Join Date: Aug 2004 Posts: 3,477	ok, interesting...this could do exactly what I want. EDIT: and it does! many Last edited by leeperry; 9th June 2010 at 03:41.

26th October 2010, 08:02	#46 \| Link
TurboPascal7 Registered User Join Date: Jan 2010 Posts: 270	Looks like a bug here. Bug appears with uvar > 0 and constant=true. Example: Right down corner. Seems to work incorrect on any resolution on yv12. Last edited by TurboPascal7; 26th October 2010 at 08:11.

27th October 2011, 00:20	#51 \| Link
Reino Registered User Join Date: Nov 2005 Posts: 686	Wow, that's quick! Thanks a lot cretindesalpes. It works like a charm. __________________ My hobby website

28th October 2011, 21:05	#55 \| Link
LaTo LaTo INV. Join Date: Jun 2007 Location: France Posts: 701	Update 1.6.0 - SSE2 I took some minutes to add SSE2 code, now it's about 50% faster. To turn off SSE2 and return to MMX set "sse2=false". Here is the new version: AddGrainC 1.6.0 __________________ AutoAdjust SmoothAdjust MCTemporalDenoise LSFmod GradFun2DBmod

2nd June 2010, 03:47	#42 \| Link
leeperry Kid for Today Join Date: Aug 2004 Posts: 3,477	..which makes me think that "seed repeatable" implies that provided I would find a "best" combination, I might be able to modify GrainF3 to always use the very same seeds/patterns....interesting!

5th June 2010, 04:17	#44 \| Link
foxyshadis ангел смерти Join Date: Nov 2004 Location: Lost Posts: 9,555	The max is probably either 2 billion or 4 billion, I forget. Any number will work about as well as any other. Every one will give you a different sequence of grain, but it'll always be identical for the same source parameters. Different colorspace or size will change everything. Give it a shot, set seed to something and keep reloading the script on different frames.

25th November 2010, 15:47	#47 \| Link
SSH4 Registered User Join Date: Nov 2006 Posts: 90	hmm, i have some bug

27th October 2011, 12:26	#53 \| Link
SSH4 Registered User Join Date: Nov 2006 Posts: 90	cretindesalpes can you check bug from TurboPascal7 post http://forum.doom9.org/showpost.php?...6&postcount=46 ?

29th October 2011, 11:29	#56 \| Link
LaTo LaTo INV. Join Date: Jun 2007 Location: France Posts: 701	Update 1.6.1 Just a one line update to add automatic switch to MMX if your cpu doesn't support SSE2. Here: AddGrainC 1.6.1 __________________ AutoAdjust SmoothAdjust MCTemporalDenoise LSFmod GradFun2DBmod

16th August 2012, 00:29	#58 \| Link
cretindesalpes ͡҉҉ ̵̡̢̛̗̘̙̜̝̞̟̠͇̊̋̌̍̎̏̿̿ Join Date: Feb 2009 Location: No support in PM Posts: 712	Update 1.7.0 AddGrainC 1.7.0 This version supports the new Avisynth 2.6 colorspaces: Y8, YV16, YV24 and YV411. __________________ dither 1.28.1 for AviSynth \| avstp 1.0.4 for AviSynth development \| fmtconv r30 for Vapoursynth & Avs+ \| trimx264opt segmented encoding

16th August 2012, 01:21	#59 \| Link
Overdrive80 Anime addict Join Date: Feb 2009 Location: Spain Posts: 675	Thanks very much for your effort __________________ Intel i7-6700K + Noctua NH-D15 + Z170A XPower G. Titanium + Kingston HyperX Savage DDR4 2x8GB + Radeon RX580 8GB DDR5 + ADATA SX8200 Pro 1 TB + Antec EDG750 80 Plus Gold Mod + Corsair 780T Graphite

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode