NLMeansCL: GPU based Non Local Means Denoising

[Malcolm]

I have uploaded version 0.2.1. I hope, now the selection of CPU devices will also work if and AMD Radeon is installed. See my first post for the download link

[GoodzMastaJ]

Version 0.2.1 on i7 860 and Radeon HD 4870. When I load my avs script, I see a couple dos windows flash by quickly but I get this error from Avisynth when using cpu=true and buffer=true. I seem to be getting a little bit closer to actually seeing what this filter does

Debug log:

NLMeansCL Version 0.2.1
ScriptEnvironment present.
Number of OpenCL Compute Platforms = 1.
Trying OpenCL Compute Platform
  Advanced Micro Devices, Inc..
  OpenCL 1.1 ATI-Stream-v2.3 (451).
OpenCL Compute Context successfully created.
Number of OpenCL Devices in Platform = 2.
Trying OpenCL Device
  ATI RV770.
  Device available.
Trying OpenCL Device
  Intel(R) Core(TM) i7 CPU         860  @ 2.80GHz.
  Device available.
  Device Type Cpu.
  Device does not support images.
Using Device Intel(R) Core(TM) i7 CPU         860  @ 2.80GHz.
OpenCL Command Queue successfully created.
OpenCL Program successfully built.
Prog Y Build log: .
Prog UV Build log: .

[Malcolm]

Originally Posted by GoodzMastaJ

Version 0.2.1 on i7 860 and Radeon HD 4870. When I load my avs script, I see a couple dos windows flash by quickly but I get this error from Avisynth when using cpu=true and buffer=true.

Hi!
the flashing of the dos windows is normal. It is caused by the AMD OpenCL driver. I will look into the remaining erro that prevents execution. I assume this is only a minor problem.

[Malcolm]

I have uploaded version 0.2.2. I really hope this is it now!

[Hiritsuki]

I want to know what "Parameter buffer", is this effect when Parameter cpu is true?
and using DDR RAM not GDDR RAM?

[tormento]

Do you have a timeframe for the temporal part? =)

[Malcolm]

Originally Posted by Hiritsuki

I want to know what "Parameter buffer", is this effect when Parameter cpu is true?

Think of it like this:
When using OpenCL image objects, the video frames are stored as textures on the gfx cards main memory. GPUs have very fast texture caches. Therefore, reading and writing from/to images is fast.
When using OpenCL buffers, the video frames are placed as 'arrays' into the main memory of the gfx card. Access is not cached. Therefore the performace is very low in comparison! (*)
When you are using a CPU as OpenCL device, this difference doesn't matter, since there are no 'texture caches' in CPUs. (memory is cached anyway)
AMD has not implemented image support in its CPU OpenCL driver yet (but it's planned!). There is no performance drawback per se as explained above. But the pity is, that you cannot execute OpenCL kernels that uses images...
AMDs RV7xxx cards don't have image support either, although they are GPUs and have texture caches for sure! It's just that the image capabilities of these GPUs is not compliant to the OpenCL spec. Therefore -> no support.

* You can get around this limitation and be faster than using images. It's just that you have to hand-tune to the exact hardware you are using and it also depends on the dimensions of the processed data. Both things are not known beforehand for avisynth filters typically (the used hardware (gfx card) and the data dimensions (video sizes)). Therefore i have implemented it only for my gfx card with hand-tuned values for 720x576 video. It's faster than using images. But it doesn't make sens to release it.

[Malcolm]

I have uploaded version 0.3. See first post.

Changes

• Added mode for sum of absolute differences when computing neighborhood similarity (Parameter sse)
• Performance improvements in cases where not all planes are processed (plane != 4)

[Hiritsuki]

Why do I setting avs in NLMeansCL(buffer=true) and it's seem...

http://imagewtf.com/11941.png/images/11941.png

[Hiritsuki]

and 0.3 All Default () is...

http://imagewtf.com/11942.png/images/11942.png

[Malcolm]

Originally Posted by Hiritsuki

Why do I setting avs in NLMeansCL(buffer=true) and it's seem...

http://imagewtf.com/11941.png/images/11941.png

Try the different values for parameter smf (nan, ahp, uhp, ...). This might solve it.
Otherwise: Please send me the XML report of GPU Caps Viewer as well as the logfile of NLMeansCL.

[Archimedes]

Version 0.2.2 works fine with NLMeansCL(cpu=true, buffer=true), but with Version 0.3 an error occurred.

Here is the log file:

NLMeansCL Version 0.3
ScriptEnvironment present.
Number of OpenCL Compute Platforms = 1.
Trying OpenCL Compute Platform
Advanced Micro Devices, Inc..
OpenCL 1.1 ATI-Stream-v2.3 (451).
Number of OpenCL Devices in Platform = 1.
Trying OpenCL Device Intel(R) Core(TM)2 Duo CPU P8700 @ 2.53GHz.
Device available.
Device Type Cpu.
Device does not support images.
Using Device Intel(R) Core(TM)2 Duo CPU P8700 @ 2.53GHz.
OpenCL Compute Context successfully created.
OpenCL Command Queue successfully created.
OpenCL Program successfully built.
Prog Y Build log:
Prog UV Build log:
OpenCL error code detected: InvalidKernelName.

[Malcolm]

I have uploaded version 0.3.1.
This should solve Archimedes and Hiritsukis problems.

Working on a theoretical basis without all the platforms for testing is really a minefield! So sorry, if it takes several iterations until it runs without hiccups!

To the change of the memory allocation strategy. The different possible OpenCL memory allocation strategies are really badly documented in the OpenCL spec. There are various discussions in OpenCL forums around it. It seems no one except NVidias and AMDs core developers knows what's really going on under the hood and how they are supposed to be used...

[Hiritsuki]

ok, this is my GPU's OpenCL XML
http://www.mediafire.com/?y04xn3m1qxfby2v

[Hiritsuki]

I just found when buffer is True, I should set NLMeansCL(smf="ahp",buffer=true) to run.
btw, using buffer is slower than all default setting.
buffer=true GPU 2~8%
buffer=false GPU 23~27%

[Dogway]

@Malcolm: Just wanted to say thanks again for this great filter. I saw az implementation on the todo list so besides that, and although Im going to stick to b=0 you might want to see the aliasing issues when b>0.

[Hiritsuki]

I just test 0.31 to compare with 0.22 speed.
0.22 is fatser than 0.31
5.5fps:5.0fps

And 0.31 GPU using is lower than 1% ... this is cannot to use GPU?

[TheProfileth]

An interesting filter, can get good results without killing details if you set the h and hc below 1 , I suggest using something like

nlmeanscl(plane=4,b=0,h=0.5,hc=0.6)

Edit:
I forgot to mention I was having problems where I got this error message
http://img510.imageshack.us/img510/8287/afag.png
But then I updated my graphics card driver to the new beta (I had the most recent stable version before) and now it works fine
http://www.nvidia.com/object/win7-wi...ta-driver.html

[tormento]

I think the TODO should contain PRESET modes a-la MCTD

[Dogway]

Originally Posted by tormento

I think the TODO should contain PRESET modes a-la MCTD

I think it's easy enough, you'd mostly use only A and H parameters