Welcome to Doom9's Forum, THE in-place to be for everyone interested in DVD conversion. Before you start posting please read the forum rules. By posting to this forum you agree to abide by the rules. |
|
|
Thread Tools | Search this Thread | Display Modes |
28th April 2009, 11:51 | #302 | Link |
Registered User
Join Date: Sep 2003
Location: On The Beach
Posts: 714
|
OK, I'll give up. I just hope that someday you will understand that I'm right. Also the SupRip join feature have this bug. Working with text subtitles for more than 5 years and I saw over that 3000 srt subtitles, checking them for errors with subtitles workshop and also I helped the author of that program for fixing some minor bugs and translating the program in my language.
Good luck! You are making a very nice job, but seems that sometimes not looking deep in some posts. Edit: just for fun, play these 3 subtitles test with any video: http://uploaded.to/file/d4bo9v Will cost you 1.30 minutes. enjoy, Mtz Last edited by Mtz; 28th April 2009 at 12:03. |
28th April 2009, 12:55 | #303 | Link | |
Registered User
Join Date: Sep 2008
Location: Sweden
Posts: 66
|
Quote:
Code:
<Event InTC="00:00:00:00" OutTC="00:00:00:16" Forced="False"> <Graphic Width="576" Height="36" X="896" Y="900">00009_0001.png</Graphic> </Event> <Event InTC="00:00:00:17" OutTC="00:00:01:16" Forced="False"> <Graphic Width="576" Height="36" X="896" Y="900">00009_0002.png</Graphic> </Event> <Event InTC="00:00:01:17" OutTC="00:00:02:16" Forced="False"> <Graphic Width="576" Height="36" X="896" Y="900">00009_0003.png</Graphic> </Event> <Event InTC="00:00:02:17" OutTC="00:00:03:16" Forced="False"> <Graphic Width="576" Height="36" X="896" Y="900">00009_0004.png</Graphic> </Event> <Event InTC="00:00:03:17" OutTC="00:00:04:16" Forced="False"> <Graphic Width="576" Height="36" X="896" Y="900">00009_0005.png</Graphic> </Event> <Event InTC="00:00:04:17" OutTC="00:00:05:16" Forced="False"> <Graphic Width="576" Height="36" X="896" Y="900">00009_0006.png</Graphic> </Event> <Event InTC="00:00:05:17" OutTC="00:00:06:16" Forced="False"> <Graphic Width="576" Height="36" X="896" Y="900">00009_0007.png</Graphic> </Event> <Event InTC="00:00:06:17" OutTC="00:00:07:16" Forced="False"> <Graphic Width="576" Height="36" X="896" Y="900">00009_0008.png</Graphic> </Event> <Event InTC="00:00:07:17" OutTC="00:00:08:16" Forced="False"> <Graphic Width="576" Height="36" X="896" Y="900">00009_0009.png</Graphic> </Event> From what I can see from the XML file, BDSup2Sub handles the in/out timings completely correctly (frame accurately). The timings in a XML file are in the format HH:MM:SS:FF, where FF is frames. The timings in a XML file are somewhat confusing - they are given as if the frame rate is 30 fps when the frame rate is actually 29.97 fps. One benefit is that the timings are completely unambiguous. Note that there is no frame missing a subtitle, they all go out in on frame 17 and out on frame 16. |
|
29th April 2009, 10:27 | #304 | Link |
Registered User
Join Date: Sep 2008
Location: Sweden
Posts: 66
|
Merging identical subtitles
0xdeadbeef,
Could you please make it an option in BDSup2Sub to merge/not merge identical subtitles if they are separated in time. I have an example where the same subtitle is shown twice, with a short brake in between. If you look at the movie, it's quite clear that they are meant to be shown like this. BDSup2Sub (v3.4.3) are merging the two into one. If I export the original SUP to XML/PNG by SUPread, one can see that the two identical subs are separated in time (three frames with no subtitle shown): Code:
<Event InTC="00:49:44:11" OutTC="00:49:47:05" forced="False"> <Event InTC="00:49:47:09" OutTC="00:49:49:14" forced="False"> Code:
<Event InTC="00:49:44:11" OutTC="00:49:49:14" Forced="False"> |
29th April 2009, 14:48 | #305 | Link |
Author of BDSup2Sub
Join Date: Jun 2003
Posts: 478
|
Currently BDSup2Sub uses a fixed time difference (200ms) to decide whether to merge identical captions or not (at least if there is a gap at all). BTW: merging is only implemented for BD-SUPs, as multiple repetition of the very same bitmap with short/no gaps is a common problem of this format (only).
The main reason for not letting the user set this value was that it's already needed during parsing. So I'd either need an additional dialog before loading the file or you'd need to reload the file after changing the option. Both seems awkward. The only proper way would be to move the merging from the parsing code to the scanning code, but this is a lot of effort. The only quick'n'dirty solution I could offer was to make this (only) a command line option for the moment. Honestely, I don't see any benefit in this anyway. In 99.99% of the cases where identical subtitles have a gap < 200ms, it's an authoring fault. And really: IMHO it seems strange to insist on getting a short flicker instead of a constant display. So, in a nutshell: while it's not impossible that some future version will implement this (as GUI option), this is about as low in priority as can be. Indeed chances are it will never happen as rewriting the parser and scanning code just for this doesn't sound very appealing to me. Last edited by 0xdeadbeef; 29th April 2009 at 14:54. |
29th April 2009, 20:45 | #307 | Link |
Registered User
Join Date: May 2008
Posts: 1,840
|
These bdn xml subs crashes the gui after loading, error log is included in the zip.
The bdn xml subs were created with avs2bdnxml. BDSupEdit loads and outputs them correctly. |
29th April 2009, 22:13 | #308 | Link | |
Author of BDSup2Sub
Join Date: Jun 2003
Posts: 478
|
Quote:
I'd assume it's a bug in the 64bit implementation of the JVM - at least that seems to be the most likely solution if your PC is stable otherwise. |
|
29th April 2009, 22:30 | #309 | Link |
Registered User
Join Date: May 2008
Posts: 1,840
|
Must be 64 bit jvm, I wonder how I'd go about reporting that. Any ideas?
Edit: Also I noticed the vobsub output can't be joined with VobSubMuxer but it works with dvd subs from gabest vobsub and subtitlecreator. Is there a chance BDSup2Sub vobsub output could be changed to support it? Edit2: I found out what's causing it. If you change these BDSup2Sub lines: Code:
# Language langidx: 0 id: en, index: 0 # Vob/Cell ID: 1, 1 (PTS: 0) Code:
# Language index in use langidx: 0 # English id: en, index: 0 # Decomment next line to activate alternative name in DirectVobSub / Windows Media Player 6.x # alt: English # Vob/Cell ID: 1, 1 (PTS: 0) Last edited by turbojet; 30th April 2009 at 07:46. |
1st May 2009, 12:01 | #311 | Link |
Author of BDSup2Sub
Join Date: Jun 2003
Posts: 478
|
Well, a comment is a comment and while it's ok to parse comments to get additional info, I would call a tool buggy that insists on certain comments instead of taking them for what they are.
Still, while I'm not really keen on adding workarounds for bugs in other people's tools I can add that in the next version. Currently, there is no support to load SUB/IDX. Then again, chances are that there will be. |
1st May 2009, 12:25 | #312 | Link | |
Registered User
Join Date: May 2008
Posts: 1,840
|
Quote:
|
|
3rd May 2009, 15:01 | #313 | Link |
Registered User
Join Date: Mar 2008
Posts: 305
|
I tried what you suggested:
http://forum.slysoft.com/showpost.ph...12&postcount=5 but even on my machine it's in: Code:
HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\JavaSoft\Java Runtime Environment Thanks anyway. |
3rd May 2009, 16:52 | #314 | Link | |
Author of BDSup2Sub
Join Date: Jun 2003
Posts: 478
|
Quote:
http://www.insidetheregistry.com/reg....asp?keyid=387 Anyway, the registry key and the suggested approach both are correct. http://java.sun.com/javase/6/webnote...e_windows.html |
|
3rd May 2009, 20:16 | #315 | Link |
Author of BDSup2Sub
Join Date: Jun 2003
Posts: 478
|
Changed too much, tested too little. So chances are I messed some things up. Side note: some (multi packet) VobSubs created by versions < 2.1 can't be imported (since they were indeed partly corrupt). Also the support for VobSub import is pretty basic currently. No detection of fading and other fancy things (yet).
03.05.2009 3.4.3 -> 3.5.0
|
3rd May 2009, 22:18 | #316 | Link | |
Special SeeD
Join Date: Nov 2002
Location: Mexico
Posts: 333
|
Quote:
Sample Sub: http://rapidshare.com/files/228836683/Bourne.rar According to subtitlecreator the timecode for the first subtitle is: 00:00:02,102 --> 00:00:04,139, and for the next subtitle is 00:00:04,238 --> 00:00:07,014, żbad timecode parsing? |
|
Thread Tools | Search this Thread |
Display Modes | |
|
|