Quote:
Originally Posted by egur
Please note my last commit:
Code:
Modified/fixed TtelecineManager class (in TvideoCodec.cpp + .h). Changed behavior to produce exactly 23.976 fps when entering film mode. Previous behavior was not producing smooth playback. In film mode time stamps are calculated from the first frame of the film sequence.
Playback wasn't smooth on many clips. averaging time stamps is not a good concept... Now it's much better with less code
|
Thanks for fix.
I've broken something when I changed the code to check only one repeat first field flag to enter film mode.
Formerly, it checked 4 frames (10 fields) and buffered them to calculate the average.
Is it safe enough to assume 23.976 fps just by detecting only one repeat first field flag?
Quote:
Code:
Re-added an initialization from SPS header (H264) of the pictIn variable used for codec initialization. Need to check if this is actually used since no one complained.
|
In my working copy for the next commit, it needs to get frame rate from SPS.
That function is now very robust and won't crash anymore. Please keep it.