Thread: MPEG2Dec3 v1.10
View Single Post
Old 20th May 2003, 18:07   #51  |  Link
trbarry
Registered User
 
trbarry's Avatar
 
Join Date: Oct 2001
Location: Gainesville FL USA
Posts: 2,092
Quote:
(edit2: The bug's in the Add_Block code, but havent found it yet, the intra/non-intra code is fine)
Nic -

I probably did something stupid there but I should be able to find it with a compare. Or I guess you can just not use the new Add_Block portion for now.

Quote:
Edit3: Forgot Marc broke the Crop support, (using crop inside dvd2avi when creating the d2v file crashes the mpeg2dec...nice. ) Ill try and fix that or at least make it so it ignores the crop params from the d2v file.
Yep, I forgot about that again too.

IIRC, the crop was also broken when I first started working on MPEG2DEC, but I fixed it. The problem originally was that it was implemented inside one of the color conversion functions of Store.cpp and wasn't adjusting for the 2:1 size difference for chroma planes.

I don't know where it should be implemented now, for YV12, since those conversion functions are hopefully not even being used. Probably just as an adjustment to the CopyAll parms.

Is it really true that this is slower than Marc FD's last version for some reason?

- Tom
trbarry is offline   Reply With Quote