View Single Post
Old 24th June 2011, 18:47   #17577  |  Link
fastplayer
Registered User
 
Join Date: Nov 2006
Posts: 799
Quote:
Originally Posted by Underground78 View Post
I am not sure to understand, it is just an hint for the user I guess so why would you need a variable to save the number of core ? However I am quite sure it was wrongly chosen and I will probably delete it.
The code basically says that anything with less than 3 cores is not suitable of running sub animations which is total nonsense of course. Especially considering that the code itself is not multithreaded at all.

My suggestion:
Code:
bool bAllowAnimationWhenBuffering = true;
SYSTEM_INFO SysInfo;
GetSystemInfo(&SysInfo);
	if (SysInfo.dwNumberOfProcessors < 3) {
                bAllowAnimationWhenBuffering = false;
}
 	
r.fSPCAllowAnimationWhenBuffering = !!pApp->GetProfileInt(IDS_R_SETTINGS, _T("SPCAllowAnimationWhenBuffering"), bAllowAnimationWhenBuffering);
replace with
Code:
r.fSPCAllowAnimationWhenBuffering = !!pApp->GetProfileInt(IDS_R_SETTINGS, _T("SPCAllowAnimationWhenBuffering"), true);
fastplayer is offline