Quote:
Originally Posted by Gabriel_Bouvigne
The 32x32 fix seems really strange, especially the "pmb = -imb;" line. Did you intended to have a negative number of P MB ?
|
It is OK because
pmb is only used for
x264_log. Also I think
imb in this situation would be always equal zero and so
pmb would be also zero (also negative value in log would indicate that something is going strange). By the way without the patch the result of
Code:
int pmb = (h->sps->i_mb_width - 2) * (h->sps->i_mb_height - 2) - imb;
would be even less predictable. If
h->sps->i_mb_width==2 or
h->sps->i_mb_height==2 then the result would be again
-imb. But if the
h->sps->i_mb_width==1 and
h->sps->i_mb_height>2 then the result would be
2-h->sps->i_mb_height-imb (and so
pmb would be negative 100%)
Quote:
Originally Posted by Ranguvar
|
No. Only when
komisar update them (it is his host, not my). Sometimes I give new versions to him directly (or post on the another forum), and sometimes post them here (as today) or in x264dev mailing list.