View Single Post
Old 10th July 2016, 14:19   #14  |  Link
MysteryX
Soul Architect
 
MysteryX's Avatar
 
Join Date: Apr 2014
Posts: 2,559
The bug with ExecuteBefore is now fixed in the code repository.

Also... why is it necessary to Dispose the VideoFrame after use? That normally shouldn't be necessary, but it crashes when closing the script if you don't.
https://github.com/mysteryx93/AvsFil...cessNet.cs#L50

Overall, it's working. Areas for improvement: parameters could be better validated to avoid erratic behaviors, and occasionally errors aren't being handled in a nice way.

Edit: For VideoFrame.Dispose, considering it's working fine during execution and only fails during the destructor, perhaps if we let the Garbage Collector release it, it doesn't care whether the Clip or VideoFrame is released first, and if it releases the Clip first, then obviously the VideoFrame is screwed up. In that case, explicitely calling VideoFrame.Dispose may be a good idea as I don't see any other way of controlling the order.

Last edited by MysteryX; 10th July 2016 at 14:42.
MysteryX is offline   Reply With Quote