View Single Post
Old 12th April 2007, 09:55   #1020  |  Link
BlindWanderer
Brain Dead
 
BlindWanderer's Avatar
 
Join Date: Nov 2003
Posts: 87
I was browsing change 1094 and i found a less then optimal line of code in 'trunk/src/ffmpeg/libavcodec/h264.c' @Line 8031
http://ffdshow-tryout.svn.sourceforg...3&pathrev=1094
Code:
while(ptr[dst_length - 1] == 0 && dst_length > 0)
Should be:
Code:
while(dst_length > 0 && ptr[dst_length - 1] == 0)
And shouldn't 8033 be
Code:
bit_length= (dst_length <= 0) ? 0 : (8*dst_length - decode_rbsp_trailing(h, ptr + dst_length - 1));
I'm kinda impressed and appalled someone grammar checked the comments.
__________________
I'll sell my soul for a cabbit.

Last edited by BlindWanderer; 12th April 2007 at 09:58.
BlindWanderer is offline   Reply With Quote