View Single Post
Old 20th September 2017, 18:12   #1369  |  Link
Bandits
Registered User
 
Join Date: Feb 2015
Posts: 43
Quote:
Originally Posted by Scorpius666 View Post
Thanks to this wonderful thread I have found that versions of BDSup2Sup higher than 5.0.0 will lose 15% of the subtitles (totally unusable), but versions 5.0.0 and lower will only lose 1% if any.

Since it still loses a couple of subtitles, I have decided to implement one of the two things missing in BDSub2Sup that makes it lose subtitles.

Basically BDSup2Sub didn't implement two things:
  • Complex compositions. This is when two or more subtitles are shown at the same time. A warning is shown that multiple ODS are defined and only one subtitle will be recognized.
  • Cropping. BluRay subtitles support showing a piece of the image each time, so a line like "Ok! Let's do it" can be shown like "Ok!" first and then "Ok! Let's do it".

The second item is not that terrible. You will only lose the "animation" of the subtitle being shown few words at a time.

But the first item is a big problem. This usually happens when a subtitle is being shown and then another one has to appear, for example a foreign sign have appeared in the screen and the person hasn't finished talking. Since compositions are very common they must be implemented.

So that's what I did here: https://github.com/naikel/BDSup2Sub/tree/enhanced

Also I tried to give a better explanation how PGS works here: http://blog.thescorpius.com/index.ph...btitle-format/
With your new version, tracks 7 and 8 on Close Encounters of the Third Kind (1977) crash.

java.lang.NullPointerException
bdsup2sub.supstream.bd.Sup.BD.(Sup.BD.java:301)
bdsup2sub.core.Core.readSup(Core.java:301)
bdsup2sub.core.Core.run(Core.java:158)
java.lang.Thread.run(Unknown Source)

With 4.0.0, you will receive error:

WARNING: missing PDS/ODS: last epoch is discarded
__________________
Blu-Ray Ripper 0.112c/0.21a
Bandits is offline   Reply With Quote