View Single Post
Old 28th September 2008, 17:57   #179  |  Link
schluppo
Guest
 
Posts: n/a
1. Will do.

2. There were a few bugs in your parameter checking (usually mixup of '<' and '>' or '>=' instead of '>' etc.). I fixed those that came to my eyes. Some are still left - see the logs. And concerning MASK_UNS: Java interprets integers as signed numbers. So when doing this:
Code:
int bla = 0xFFFFFFFF;
if (bla>0x10) return 0x80000001;
return 0;
it will return 0 (since 0xFFFFFFFF is interpreted as a negative number), but for parameter checks we would want it to return 0x80000001 in this case. Hence I masked the first bit to avoid this trouble. Since it works as it is and my time is limited, feel free to work around this problem in any other way (by using longs to hold the parameters?).

3. Done

4. Will do so, if I find the time.

On another note: What you said so far about TRAP_PrivateKey can easily be coded
  Reply With Quote