jeanl
4th May 2005, 23:08
Hi guys,
As you may or may not know, the preview part of PgcEdit and Vobblanker uses the original DVD2AVI code that jsoto modified a bit, and which I packaged as a class (called DVDPreview) to be used in, say, MFC apps. This is what PgcEdit and vobblanker (and menushrink) use for their preview.
Recently, blutach found a VOB that simply wouldn't display correctly in the preview (see this (http://forum.doom9.org/showthread.php?s=&postid=648958#post648958)). I traced the problem down to a part of the original DVD2AVI code (the function MPEG2Dec(LPVOID n)) where the original author wrote:
// This code is designed to ignore false (emulated) leading
// SEQUENCE_HEADER_CODEs. But it precludes decoding MPEG1
// because it would trigger this. I'll wait until I see
// how real the issue is before doing anything. So far it is
// just one VOB reported and the notifier no longer even has
// it.
The problem comes from the fact that DVD2AVI thinks it sees a SEQUENCE_HEADER_CODE, but in fact, it's looking inside a navpack (!), see this (http://forum.doom9.org/showthread.php?s=&postid=649392#post649392) to see why that is. Of course, from then on, things don't go really well! ;)
The DVDPreview code is based on version 110 of DVD2AVI. I'm wondering if DGIndex offers a solution to the problem, if other people have encountered the issue, and if there's been a workaround.
In nearly 1 year of use as a preview for vobblanker (and a bit less for pgcedit), I think this is the first time the problem has occurred, so it's not really critical.
I welcome any comments/suggestions!
jeanl
As you may or may not know, the preview part of PgcEdit and Vobblanker uses the original DVD2AVI code that jsoto modified a bit, and which I packaged as a class (called DVDPreview) to be used in, say, MFC apps. This is what PgcEdit and vobblanker (and menushrink) use for their preview.
Recently, blutach found a VOB that simply wouldn't display correctly in the preview (see this (http://forum.doom9.org/showthread.php?s=&postid=648958#post648958)). I traced the problem down to a part of the original DVD2AVI code (the function MPEG2Dec(LPVOID n)) where the original author wrote:
// This code is designed to ignore false (emulated) leading
// SEQUENCE_HEADER_CODEs. But it precludes decoding MPEG1
// because it would trigger this. I'll wait until I see
// how real the issue is before doing anything. So far it is
// just one VOB reported and the notifier no longer even has
// it.
The problem comes from the fact that DVD2AVI thinks it sees a SEQUENCE_HEADER_CODE, but in fact, it's looking inside a navpack (!), see this (http://forum.doom9.org/showthread.php?s=&postid=649392#post649392) to see why that is. Of course, from then on, things don't go really well! ;)
The DVDPreview code is based on version 110 of DVD2AVI. I'm wondering if DGIndex offers a solution to the problem, if other people have encountered the issue, and if there's been a workaround.
In nearly 1 year of use as a preview for vobblanker (and a bit less for pgcedit), I think this is the first time the problem has occurred, so it's not really critical.
I welcome any comments/suggestions!
jeanl