View Full Version : @devs: ok if I commit this structure change.
sh0dan
26th November 2003, 12:45
This is mainly aimed at Richard Berg.
I just got some motivation for restructuring the source code. I've arranged the code in the following directories:
The distrib/docs have not been changed.
\distrib
\distrib\bin
\distrib\bin\debug
\distrib\Examples
\distrib\include
\distrib\include\il
\distrib\include\SoftWire
\distrib\lib
\distrib\lib\debug
\docs
\docs\english
\docs\english\CoreFilters
\docs\english\ExternalFilters
\docs\filters
\docs_ger
\docs_ger\filters
\src
\src\audio
\src\convert
\src\core
\src\core\parser
\src\filters
\src\filters\conditional
\src\sources
\src\sources\avi
I've updated the project and header files, but I'd just like to have your go before I commit.
WarpEnterprises
26th November 2003, 16:55
\docs
\docs\english
\docs\english\CoreFilters
\docs\english\ExternalFilters
\docs\filters
\docs_ger
\docs_ger\filters
Isn't this somewhat inconsistent?
I would prefer to keep it as it is.
For including external filters a Dir
\docs\externalfilters
and
\docs_ger\externalfilters
seems more straight to me.
And please, no uppercases as some web browsers/servers are case sensitive.
[edit]
Now I see the doc struct IS already changed.
Could someone tell me why and where to place what?
I thought only the CHM files should go to the new dirs?
bill_baroud
26th November 2003, 17:22
Just a little question ....
why
\docs\english
...
\docs_ger
and not
\docs\
\docs\english
...
\docs\german
...
\docs\french (perhaps ;p)
It's more "logical" to me :confused:
sh0dan
26th November 2003, 18:30
I think Wilbert is in the middle of restructuring the docs section as we speak.
Wilbert
26th November 2003, 19:06
The new structure will be:
\docs\
\docs\english\corefilters
\docs\english\externalplugins
...
\docs\german\corefilters
\docs\german\externalplugins
...
\docs\french\corefilters
\docs\french\externalplugins
...
The following will be removed:
\docs\filters
\docs_ger
\docs_ger\filters
But for now, I left them there so that arlsair can finish his german updates (otherwise he can't see what documents we updated during the last months). So, don't worry about that.
@WarpEnterprises,
And please, no uppercases as some web browsers/servers are case sensitive.
I didn't realise that. If arlsair updated the docs, I will change that.
Could someone tell me why and where to place what?
See above.
I thought only the CHM files should go to the new dirs?
We decided not to include compiled files in those directories. Just check the documentation out, open the project file (english.hhp), and you can directly compile the english.chm file (using Microsoft HTML Workshop). I will sent you a pm how to do that.
A recent chm file can be found in this thread (one of the last posts):
http://forum.doom9.org/showthread.php?s=&threadid=65016
If everything is ready people can download the chm-file and also the avs-editor from sourceforge. I have been quite busy the last ten days, so I didn't have time to work on this.
Regards,
Wilbert
sh0dan
26th November 2003, 19:19
Originally posted by Wilbert
But for now, I left them there so that arlsair can finish his german updates (otherwise he can't see what documents we updated during the last months). So, don't worry about that.
Actually they will be placed in "Attic" once they have been removed. So changes can still be seen.
Richard Berg
26th November 2003, 21:30
I think we hashed out the basics of this over PM a few weeks ago. I have no problem with it.
sh0dan
26th November 2003, 22:45
Great - I'll commit the update tomorrow!
Bidoche
26th November 2003, 23:57
I'd rather it match the structure I have made for 3.0, but it may be overkill...
I am exploding each filter into its own header/source file and unless you want to do that, there is no point in putting audio.h/cpp in filter/audio/.
Anyway, good call to sort the files a bit :)
When we are at it, what about using namespaces ?
I define everything in 3.0 in namespace avs, and filters in namespace filters.
And I may define others later when the need arise.
arlsair
27th November 2003, 01:20
Originally posted by Wilbert
But for now, I left them there so that arlsair can finish his german updates (otherwise he can't see what documents we updated during the last months). So, don't worry about that.
I updated the cvs files on my pc, so I can follow the changes (I hope so).
Originally posted by Wilbert
@WarpEnterprises,
I didn't realise that. If arlsair updated the docs, I will change that.
I will make the change instantly, so you don`t have to edit.
WarpEnterprises
27th November 2003, 08:32
@Wilbert:
What about the .css files and the index.htm?
Will it be
\docs\ <-- here all stylesheets,...
\docs\german\ <-- here the appropriate index.htm, syntax.,...
or each language completely separated (a css,... for each).
And where to (!modestly!) put pictures? It would help alot sometimes and the pictures should be (mainly) language-independent (for bandwith-reasons at least)
So maybe add a:
\docs\pictures
Wilbert
27th November 2003, 10:44
Will it be
\docs\ <-- here all stylesheets,...
\docs\german\ <-- here the appropriate index.htm, syntax.,...
or each language completely separated (a css,... for each).
The former. I don't see why to use different stylesheets for different languages. I tried to 'copy' the original style as much as possible.
And where to (!modestly!) put pictures? It would help alot sometimes and the pictures should be (mainly) language-independent (for bandwith-reasons at least)
So maybe add a:
\docs\pictures
Good idea. I will do that.
sh0dan
27th November 2003, 10:54
Originally posted by Bidoche
I'd rather it match the structure I have made for 3.0, but it may be overkill...
I am exploding each filter into its own header/source file and unless you want to do that, there is no point in putting audio.h/cpp in filter/audio/.
Anyway, good call to sort the files a bit :)
Regarding exploding. For separate filters it's a very good idea. I have split up source.cpp, and made avisource and directshowsource as separate files (it was getting huge!).
audio.cpp might get the same treatment some day, that's why I made it separate. Besides, there is already three more files related to SSRC audio resampling, so keeping it separate seemed like a good idea already.
When we are at it, what about using namespaces ?
I think it'll be better to just do it, as filters are ported anyway. Right now i don't feel there is a problem.
I have committed the changes - it'll be a few hours before ViewCVS is updated.
Bidoche
27th November 2003, 23:10
Regarding exploding. For separate filters it's a very good idea. I have split up source.cpp, and made avisource and directshowsource as separate files (it was getting huge!).
If you happen to do more, please try choose to match those I already made for 3.0 (when existing).
It will be easier to synchronize later.
I think it'll be better to just do it, as filters are ported anyway. Here you got me confused, what is the point of filters being ported there...
vBulletin® v3.8.5, Copyright ©2000-2012, Jelsoft Enterprises Ltd.