Manao
11th November 2003, 18:06
I think there is a bug in the masktools. With a basic script like this :
result = source.MaskedMerge(source,mask,Y=3,U=3,V=3)
return resultI don't get the original input ( whatever the mask : for example, mask = source, or a 'real' mask ). The picture is "greenish". When I look at the documentation, I see that maskedmerge should return (255-mask)*source + mask*source, but looking in the code of MMerge_C, I see it returns (256-mask)*source + mask*source. However, the code of MMerge_MMX seems correct ( but I'm far from an assembler expert, especially since I've just discovered the different MMX operations ), and it should be this one which is used, since I have an athlon xp.
Can anyone confirm the bug, and recompile a version of the masktools at least with a correct MMerge_C function ?
And, by the way, why does the author of the masktools say at the end of his readme that development is stopped because users prefers ConditionnalFiltering : it isn't the same thing ( or I didn't understand how works ConditionnalFiltering ).
result = source.MaskedMerge(source,mask,Y=3,U=3,V=3)
return resultI don't get the original input ( whatever the mask : for example, mask = source, or a 'real' mask ). The picture is "greenish". When I look at the documentation, I see that maskedmerge should return (255-mask)*source + mask*source, but looking in the code of MMerge_C, I see it returns (256-mask)*source + mask*source. However, the code of MMerge_MMX seems correct ( but I'm far from an assembler expert, especially since I've just discovered the different MMX operations ), and it should be this one which is used, since I have an athlon xp.
Can anyone confirm the bug, and recompile a version of the masktools at least with a correct MMerge_C function ?
And, by the way, why does the author of the masktools say at the end of his readme that development is stopped because users prefers ConditionnalFiltering : it isn't the same thing ( or I didn't understand how works ConditionnalFiltering ).