PDA

View Full Version : Changes for new SKAL IDCT

MatMaul
18th July 2006, 17:37
I have modified dgindex and dgdecode to include the new skal sse2 idct, but I have some problems to compile (with the original version also).
Anyone can compile it ?

http://www.mytempdir.com/811189

(the diff file is for the version 1.4.7 source code)
Adub
18th July 2006, 18:36
You did this with neuron2's permission, right?
If so, Great! I have been waiting for that integration!
MatMaul
18th July 2006, 21:25
euh... no, but it's a GPL software !

I have made a mistake in the first patch, new version of the patch : http://www.mytempdir.com/811732

use idct=8 to use the new idct.

I haven't test it because I don't now how compile it, I have a lot of errors when I try to compile with VS2005 (I think I don't have all the needed libraries).
neuron2
19th July 2006, 03:01
I moved this because it's 1.4.7-related and so is not appropriate for my 1.4.8 feedback thread.
squid_80
19th July 2006, 03:19
My tests have shown skal's new SSE2 idct to be slower than the existing SSE2 version, while producing identical results.
neuron2
19th July 2006, 03:37
And my tests showed an insignificant difference, which is why I didn't bother to incorporate it.
squid_80
19th July 2006, 03:56
I wondered why I felt deja vu while typing that...
http://forum.doom9.org/showthread.php?p=727384#post727384

And Skal was right, with low bitrates (=high quantizers) his idct was faster due to it's early termination checks. But that didn't happen when I used "common" material.